From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69366 invoked by alias); 18 Dec 2018 22:40:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69304 invoked by uid 89); 18 Dec 2018 22:40:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt1-f194.google.com Received: from mail-qt1-f194.google.com (HELO mail-qt1-f194.google.com) (209.85.160.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Dec 2018 22:40:06 +0000 Received: by mail-qt1-f194.google.com with SMTP id l12so18236492qtf.8 for ; Tue, 18 Dec 2018 14:40:06 -0800 (PST) Return-Path: Received: from [192.168.1.149] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id c77sm1126280qkh.82.2018.12.18.14.40.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Dec 2018 14:40:04 -0800 (PST) Subject: Re: [C++ PATCH] Constexpr fold even some TREE_CONSTANT ctors (PR c++/87934) To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20181218204517.GS23305@tucnak> From: Jason Merrill Message-ID: Date: Tue, 18 Dec 2018 22:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20181218204517.GS23305@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg01349.txt.bz2 On 12/18/18 3:45 PM, Jakub Jelinek wrote: > The following testcase FAILs, because parsing creates a TREE_CONSTANT > CONSTRUCTOR that contains CONST_DECL elts. cp_fold_r can handle that, > but constexpr evaluation doesn't touch those CONSTRUCTORs. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? OK. I also wonder if store_init_value should use cp_fold_r rather than just cp_fully_fold. Jason