From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id C39A03871F89 for ; Fri, 16 Dec 2022 13:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C39A03871F89 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CA7443413B; Fri, 16 Dec 2022 13:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1671197786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+x9RwsK+Aj/Y8mnNAQ/Z088mM/CqwFwQpl/3TCdXw0=; b=oebNMguDnY3e5omx8D1jXN+sbIBn8/VgOlMv/XmRLb2/z61siXSxZzc0eYwtDEyexyRGKZ jYtGvPC2FGG0HQrLMhdkcq1nUCtp2RhboiXhyaMbn074ypZWeAMsg2aCyHVgmMeuYsqIV2 ihGapdDB/n1iugShDmwE11i/KDPGtL8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1671197786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V+x9RwsK+Aj/Y8mnNAQ/Z088mM/CqwFwQpl/3TCdXw0=; b=trSrz9RhsPZusul0amZ33QCheKrn4RHMaMMLuLhNnUaHE99UXCpj1ijKDqyYEPlly8DQDJ /8xFy/iDAuuk1uBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B63B0138F0; Fri, 16 Dec 2022 13:36:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5mWaK1p0nGNtTgAAMHmgww (envelope-from ); Fri, 16 Dec 2022 13:36:26 +0000 Content-Type: multipart/mixed; boundary="------------O7D5rwZv0EIFswIC3Nu5QAt9" Message-ID: Date: Fri, 16 Dec 2022 14:36:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [Patch] gcc-changelog: Add warning for auto-added files Content-Language: en-US To: Tobias Burnus , gcc-patches References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------O7D5rwZv0EIFswIC3Nu5QAt9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/16/22 13:33, Tobias Burnus wrote: > Thus, the auto-add feature does not seem to be an often used feature - neither on > purpose nor accidentally. And glancing at the results, I think it was as often used > on purpose as it was used accidentally. Hello. Understood, I do support the newly added warning with a small patch tweak. > > I was wondering whether the commit hook should print this warning/note or not. I would print it. > It can be helpful in case something too much got committed, but for the usual > case that the file was missed, it simply comes too late. (Frankly, I don't > know whether the hook currently runs with '-v' or not.) Cheers, Martin --------------O7D5rwZv0EIFswIC3Nu5QAt9 Content-Type: text/x-patch; charset=UTF-8; name="tweak.patch" Content-Disposition: attachment; filename="tweak.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvZ2NjLWNoYW5nZWxvZy9naXRfY29tbWl0LnB5IGIvY29u dHJpYi9nY2MtY2hhbmdlbG9nL2dpdF9jb21taXQucHkKaW5kZXggYjlhNjAzMTIwOTkuLmU4 MmZiY2FjZDNlIDEwMDc1NQotLS0gYS9jb250cmliL2djYy1jaGFuZ2Vsb2cvZ2l0X2NvbW1p dC5weQorKysgYi9jb250cmliL2djYy1jaGFuZ2Vsb2cvZ2l0X2NvbW1pdC5weQpAQCAtMjIs NiArMjIsNyBAQCBpbXBvcnQgZGlmZmxpYgogaW1wb3J0IG9zCiBpbXBvcnQgcmUKIGltcG9y dCBzeXMKK2Zyb20gY29sbGVjdGlvbnMgaW1wb3J0IGRlZmF1bHRkaWN0CiAKIGRlZmF1bHRf Y2hhbmdlbG9nX2xvY2F0aW9ucyA9IHsKICAgICAnYysrdG9vbHMnLApAQCAtNzA3LDcgKzcw OCw3IEBAIGNsYXNzIEdpdENvbW1pdDoKICAgICAgICAgICAgICAgICBtc2cgKz0gZicgKGRp ZCB5b3UgbWVhbiAie2NhbmRpZGF0ZXNbMF19Ij8pJwogICAgICAgICAgICAgICAgIGRldGFp bHMgPSAnXG4nLmpvaW4oZGlmZmxpYi5EaWZmZXIoKS5jb21wYXJlKFtmaWxlXSwgW2NhbmRp ZGF0ZXNbMF1dKSkucnN0cmlwKCkKICAgICAgICAgICAgIHNlbGYuZXJyb3JzLmFwcGVuZChF cnJvcihtc2csIGZpbGUsIGRldGFpbHMpKQotICAgICAgICBhdXRvX2FkZF93YXJuaW5ncyA9 IHt9CisgICAgICAgIGF1dG9fYWRkX3dhcm5pbmdzID0gZGVmYXVsdGRpY3QobGlzdCkKICAg ICAgICAgZm9yIGZpbGUgaW4gc29ydGVkKGNoYW5nZWRfZmlsZXMgLSBtZW50aW9uZWRfZmls ZXMpOgogICAgICAgICAgICAgaWYgbm90IHNlbGYuaW5faWdub3JlZF9sb2NhdGlvbihmaWxl KToKICAgICAgICAgICAgICAgICBpZiBmaWxlIGluIHNlbGYubmV3X2ZpbGVzOgpAQCAtNzQw LDEwICs3NDEsNyBAQCBjbGFzcyBHaXRDb21taXQ6CiAgICAgICAgICAgICAgICAgICAgICAg ICBmaWxlID0gZmlsZVtsZW4oZW50cnkuZm9sZGVyKTpdLmxzdHJpcCgnLycpCiAgICAgICAg ICAgICAgICAgICAgICAgICBlbnRyeS5saW5lcy5hcHBlbmQoJ1x0KiAlczogTmV3IGZpbGUu JyAlIGZpbGUpCiAgICAgICAgICAgICAgICAgICAgICAgICBlbnRyeS5maWxlcy5hcHBlbmQo ZmlsZSkKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIGVudHJ5LmZvbGRlciBub3QgaW4g YXV0b19hZGRfd2FybmluZ3M6Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgYXV0b19h ZGRfd2FybmluZ3NbZW50cnkuZm9sZGVyXSA9IFtmaWxlXQotICAgICAgICAgICAgICAgICAg ICAgICAgZWxzZToKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBhdXRvX2FkZF93YXJu aW5nc1tlbnRyeS5mb2xkZXJdLmFwcGVuZChmaWxlKQorICAgICAgICAgICAgICAgICAgICAg ICAgYXV0b19hZGRfd2FybmluZ3NbZW50cnkuZm9sZGVyXS5hcHBlbmQoZmlsZSkKICAgICAg ICAgICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICAgICAgICAgIG1zZyA9ICdu ZXcgZmlsZSBpbiB0aGUgdG9wLWxldmVsIGZvbGRlciBub3QgbWVudGlvbmVkIGluIGEgQ2hh bmdlTG9nJwogICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5lcnJvcnMuYXBwZW5kKEVy cm9yKG1zZywgZmlsZSkpCkBAIC03NjMsMTEgKzc2MSw5IEBAIGNsYXNzIEdpdENvbW1pdDoK ICAgICAgICAgICAgICAgICBzZWxmLmVycm9ycy5hcHBlbmQoRXJyb3IoZXJyb3IsIHBhdHRl cm4pKQogICAgICAgICBmb3IgZW50cnksIHZhbCBpbiBhdXRvX2FkZF93YXJuaW5ncy5pdGVt cygpOgogICAgICAgICAgICAgaWYgbGVuKHZhbCkgPT0gMToKLSAgICAgICAgICAgICAgICBz ZWxmLndhcm5pbmdzLmFwcGVuZCgnQXV0by1hZGRlZCBuZXcgZmlsZSBcJyVzLyVzXCcnCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJSAoZW50cnksIHZhbFswXSkp CisgICAgICAgICAgICAgICAgc2VsZi53YXJuaW5ncy5hcHBlbmQoZiJBdXRvLWFkZGVkIG5l dyBmaWxlICd7ZW50cnl9L3t2YWxbMF19JyIpCiAgICAgICAgICAgICBlbHNlOgotICAgICAg ICAgICAgICAgIHNlbGYud2FybmluZ3MuYXBwZW5kKCdBdXRvLWFkZGVkICVkIG5ldyBmaWxl cyBpbiBcJyVzXCcnCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJSAo bGVuKHZhbCksIGVudHJ5KSkKKyAgICAgICAgICAgICAgICBzZWxmLndhcm5pbmdzLmFwcGVu ZChmIkF1dG8tYWRkZWQge2xlbih2YWwpfSBuZXcgZmlsZXMgaW4gJ3tlbnRyeX0nIikKIAog ICAgIGRlZiBjaGVja19mb3JfY29ycmVjdF9jaGFuZ2Vsb2coc2VsZik6CiAgICAgICAgIGZv ciBlbnRyeSBpbiBzZWxmLmNoYW5nZWxvZ19lbnRyaWVzOgoK --------------O7D5rwZv0EIFswIC3Nu5QAt9--