From: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
To: Thomas Schwinge <tschwinge@baylibre.com>,
gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org
Cc: Arthur Cohen <arthur.cohen@embecosm.com>
Subject: Re: build: Don't check for host-prefixed 'cargo' program
Date: Mon, 15 Apr 2024 14:18:53 +0200 [thread overview]
Message-ID: <d5f5e3c8-909c-40c2-8243-f74b8e2a41ca@embecosm.com> (raw)
In-Reply-To: <87a5luetfd.fsf@euler.schwinge.ddns.net>
Hi,
On 4/15/24 1:50 PM, Thomas Schwinge wrote:
>> I now wonder: instead of 'AC_CHECK_TOOL', shouldn't this use
>> 'AC_CHECK_PROG'? (We always want plain 'cargo', not host-prefixed
>> 'aarch64-linux-gnu-cargo' etc., right?) I'll look into changing this.
This is a mistake, we should use 'AC_CHECK_PROG'.
> OK to push "build: Don't check for host-prefixed 'cargo' program", see
> attached?
Yes, attached patch looks good, thank you!
Regards,
--
Patry Pierre-Emmanuel
Compiler Engineer - Embecosm
next prev parent reply other threads:[~2024-04-15 12:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 16:33 [PATCH] build: Check for cargo when building rust language pierre-emmanuel.patry
2024-04-09 7:42 ` Richard Biener
2024-04-09 7:47 ` John Paul Adrian Glaubitz
2024-04-09 8:00 ` Jakub Jelinek
2024-04-09 8:29 ` John Paul Adrian Glaubitz
2024-04-09 10:40 ` Arthur Cohen
2024-04-09 8:55 ` Iain Sandoe
2024-04-09 12:01 ` Arthur Cohen
2024-04-09 10:09 ` Iain Sandoe
2024-04-09 13:53 ` Arthur Cohen
2024-04-09 14:12 ` Andrew Pinski
2024-04-09 14:25 ` Arthur Cohen
2024-04-15 11:14 ` Thomas Schwinge
2024-04-15 11:50 ` build: Don't check for host-prefixed 'cargo' program (was: [PATCH] build: Check for cargo when building rust language) Thomas Schwinge
2024-04-15 12:18 ` Pierre-Emmanuel Patry [this message]
2024-04-15 12:44 ` build: Use of cargo not yet supported here in Canadian cross configurations " Thomas Schwinge
2024-04-15 16:36 ` build: Use of cargo not yet supported here in Canadian cross configurations Pierre-Emmanuel Patry
2024-04-16 8:55 ` Arthur Cohen
2024-04-16 20:34 ` [PATCH] build: Check for cargo when building rust language Andrew Pinski
2024-04-17 8:13 ` Rainer Orth
2024-04-17 14:54 ` Arthur Cohen
2024-04-23 8:52 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5f5e3c8-909c-40c2-8243-f74b8e2a41ca@embecosm.com \
--to=pierre-emmanuel.patry@embecosm.com \
--cc=arthur.cohen@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc-rust@gcc.gnu.org \
--cc=tschwinge@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).