From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id D6A723858D37 for ; Mon, 29 Aug 2022 03:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D6A723858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxX+AUNAxj5aALAA--.51541S2; Mon, 29 Aug 2022 11:35:48 +0800 (CST) Subject: Re: [PATCH] LoongArch: testsuite: refine __tls_get_addr tests with tls_native To: Xi Ruoyao , gcc-patches@gcc.gnu.org References: <37c4ff2310c2ea983aa2d1215b381af312ad1fed.camel@xry111.site> From: Lulu Cheng Message-ID: Date: Mon, 29 Aug 2022 11:35:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <37c4ff2310c2ea983aa2d1215b381af312ad1fed.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxX+AUNAxj5aALAA--.51541S2 X-Coremail-Antispam: 1UD129KBjvJXoWfJF4kGFWfur1fXw1ftrWDurg_yoWDAFy8p3 9rJr1vqFWfJFZ7G3Z5Xr1aqa93Xr47GrWa9ws3JrWI9rsrtry2qaykKa4xJa1UXa1UXFy2 9ay293W2v3WvqwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvFb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4 vEx4A2jsIEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVAC Y4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJV W8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG 8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y 6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AK xVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvj xUgg_TUUUUU X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM! Thanks. 在 2022/8/24 下午10:09, Xi Ruoyao 写道: > If GCC is not built with a working linker for the target (developers > occansionally build such a "minimal" GCC for testing and debugging), > TLS will be emulated and __tls_get_addr won't be used. Refine those > tests depending on __tls_get_addr with tls_native to avoid test > failures. > > gcc/testsuite/ChangeLog: > > * gcc.target/loongarch/func-call-medium-1.c: Refine test > depending on __tls_get_addr with { target tls_native }. > * gcc.target/loongarch/func-call-medium-2.c: Likewise. > * gcc.target/loongarch/func-call-medium-3.c: Likewise. > * gcc.target/loongarch/func-call-medium-4.c: Likewise. > * gcc.target/loongarch/func-call-medium-5.c: Likewise. > * gcc.target/loongarch/func-call-medium-6.c: Likewise. > * gcc.target/loongarch/func-call-medium-7.c: Likewise. > * gcc.target/loongarch/func-call-medium-8.c: Likewise. > * gcc.target/loongarch/tls-gd-noplt.c: Likewise. > --- > gcc/testsuite/gcc.target/loongarch/func-call-medium-1.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-2.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-3.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-4.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-5.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-6.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-7.c | 2 +- > gcc/testsuite/gcc.target/loongarch/func-call-medium-8.c | 3 ++- > gcc/testsuite/gcc.target/loongarch/tls-gd-noplt.c | 2 +- > 9 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-1.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-1.c > index 276d73e5ee8..6339e832fe5 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-1.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-1.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*la\.global\t.*g\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*la\.global\t.*f\n\tjirl" } } */ > /* { dg-final { scan-assembler "test2:.*la\.local\t.*l\n\tjirl" } } */ > -/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" } } */ > +/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" { target tls_native } } } */ > > extern void g (void); > void > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-2.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-2.c > index 237821c066b..a53e75e0bf9 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-2.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-2.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*la\.global\t.*g\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*la\.local\t.*f\n\tjirl" } } */ > /* { dg-final { scan-assembler "test2:.*la\.local\t.*l\n\tjirl" } } */ > -/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" } } */ > +/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" { target tls_native } } } */ > > extern void g (void); > void > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-3.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-3.c > index 9a6e16103bc..0da7bf98e3c 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-3.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-3.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*la\.global\t.*g\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*la\.global\t.*f\n\tjirl" } } */ > /* { dg-final { scan-assembler "test2:.*la\.local\t.*l\n\tjirl" } } */ > -/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" } } */ > +/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" { target tls_native } } } */ > > extern void g (void); > void > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-4.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-4.c > index 2577e345239..0219688ae80 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-4.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-4.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*la\.global\t.*g\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*la\.local\t.*f\n\tjirl" } } */ > /* { dg-final { scan-assembler "test2:.*la\.local\t.*l\n\tjirl" } } */ > -/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" } } */ > +/* { dg-final { scan-assembler "test3:.*la\.global\t.*\_\_tls\_get\_addr" { target tls_native } } } */ > > extern void g (void); > void > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-5.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-5.c > index d70b6ea4663..8a47b5afcba 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-5.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-5.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*pcalau12i.*%pc_hi20\\(g\\)\n\tjirl.*pc_lo12\\(g\\)" } } */ > /* { dg-final { scan-assembler "test1:.*pcalau12i.*%pc_hi20\\(f\\)\n\tjirl.*%pc_lo12\\(f\\)" } } */ > /* { dg-final { scan-assembler "test2:.*pcalau12i.*%pc_hi20\\(l\\)\n\tjirl.*%pc_lo12\\(l\\)" } } */ > -/* { dg-final { scan-assembler "test3:.*pcalau12i.*%pc_hi20\\(__tls_get_addr\\)\n\t.*\n\tjirl.*%pc_lo12\\(__tls_get_addr\\)" } } */ > +/* { dg-final { scan-assembler "test3:.*pcalau12i.*%pc_hi20\\(__tls_get_addr\\)\n\t.*\n\tjirl.*%pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > > extern void g (void); > > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-6.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-6.c > index f963a99441a..1e75e60e01a 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-6.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-6.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*pcalau12i.*%pc_hi20\\(g\\)\n\tjirl.*pc_lo12\\(g\\)" } } */ > /* { dg-final { scan-assembler "test1:.*pcalau12i.*%pc_hi20\\(f\\)\n\tjirl.*%pc_lo12\\(f\\)" } } */ > /* { dg-final { scan-assembler "test2:.*pcalau12i.*%pc_hi20\\(l\\)\n\tjirl.*%pc_lo12\\(l\\)" } } */ > -/* { dg-final { scan-assembler "test3:.*pcalau12i.*%pc_hi20\\(__tls_get_addr\\)\n\t.*\n\tjirl.*%pc_lo12\\(__tls_get_addr\\)" } } */ > +/* { dg-final { scan-assembler "test3:.*pcalau12i.*%pc_hi20\\(__tls_get_addr\\)\n\t.*\n\tjirl.*%pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > > extern void g (void); > > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-7.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-7.c > index f2818b2da76..9e89085ca19 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-7.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-7.c > @@ -3,7 +3,7 @@ > /* { dg-final { scan-assembler "test:.*pcalau12i\t.*%got_pc_hi20\\(g\\)\n\tld\.d\t.*%got_pc_lo12\\(g\\)\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*pcalau12i\t.*%got_pc_hi20\\(f\\)\n\tld\.d\t.*%got_pc_lo12\\(f\\)\n\tjirl" } } */ > /* { dg-final { scan-assembler "test2:.*pcalau12i\t.*%pc_hi20\\(l\\)\n\tjirl.*%pc_lo12\\(l\\)" } } */ > -/* { dg-final { scan-assembler "test3:.*pcalau12i.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" } } */ > +/* { dg-final { scan-assembler "test3:.*pcalau12i.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > > > extern void g (void); > diff --git a/gcc/testsuite/gcc.target/loongarch/func-call-medium-8.c b/gcc/testsuite/gcc.target/loongarch/func-call-medium-8.c > index 7fa873d84bb..fde9c6e0ef4 100644 > --- a/gcc/testsuite/gcc.target/loongarch/func-call-medium-8.c > +++ b/gcc/testsuite/gcc.target/loongarch/func-call-medium-8.c > @@ -3,7 +3,8 @@ > /* { dg-final { scan-assembler "test:.*pcalau12i\t.*%got_pc_hi20\\(g\\)\n\tld\.d\t.*%got_pc_lo12\\(g\\)\n\tjirl" } } */ > /* { dg-final { scan-assembler "test1:.*pcalau12i\t.*%pc_hi20\\(f\\)\n\tjirl.*%pc_lo12\\(f\\)" } } */ > /* { dg-final { scan-assembler "test2:.*pcalau12i\t.*%pc_hi20\\(l\\)\n\tjirl.*%pc_lo12\\(l\\)" } } */ > -/* { dg-final { scan-assembler "test3:.*pcalau12i.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" } } */ > +/* { dg-final { scan-assembler "test3:.*pcalau12i.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > +/* { dg-final { scan-assembler "test3:.*pcalau12i.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > > extern void g (void); > > diff --git a/gcc/testsuite/gcc.target/loongarch/tls-gd-noplt.c b/gcc/testsuite/gcc.target/loongarch/tls-gd-noplt.c > index 375663286f0..9432c477e9d 100644 > --- a/gcc/testsuite/gcc.target/loongarch/tls-gd-noplt.c > +++ b/gcc/testsuite/gcc.target/loongarch/tls-gd-noplt.c > @@ -1,6 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-O0 -fno-plt -mcmodel=normal -mexplicit-relocs" } */ > -/* { dg-final { scan-assembler "pcalau12i\t.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" } } */ > +/* { dg-final { scan-assembler "pcalau12i\t.*%got_pc_hi20\\(__tls_get_addr\\)\n\tld\.d.*%got_pc_lo12\\(__tls_get_addr\\)" { target tls_native } } } */ > > __attribute__ ((tls_model ("global-dynamic"))) __thread int a; >