From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buffalo.birch.relay.mailchannels.net (buffalo.birch.relay.mailchannels.net [23.83.209.24]) by sourceware.org (Postfix) with ESMTPS id 19F093858D37 for ; Mon, 23 Oct 2023 16:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19F093858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19F093858D37 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=23.83.209.24 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698079232; cv=pass; b=fZVqasEFmX7Vj4gy16H5FCFuWYzM2HHILjo6joMWD3O6QwEgJsflUqlVxg4TQKCZiD0lGbNPFAfOJmQ99InXwb6uZaghThLA5rUYRXbR/ikkXN7sZFzOv+Sg6+6HwZ8zxzYsiqB7FYoyHkTWJtxhHdTYusPz/UkiCUakKhWRyXA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698079232; c=relaxed/simple; bh=2y5JkFTubuJnnypxMtoU7CkfjNIrEPyHpC8ttFNLW0c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Yea3vXWiM0M8ep2/05E0mG1GehJVbEsP7BlD2ZUVsscTjYahiIEGVdZSFOs2fHOXibWuxOTrstWRqjsz2XBg2xy3BW2MNinxWlJvMieujEtapbt05JmTc0xU3DR8RKv/34ybFOUjS+bnAF1xRsnBCKdel/7blZKPI7nEXY1e0BI= ARC-Authentication-Results: i=2; server2.sourceware.org X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AEEC054143A; Mon, 23 Oct 2023 16:40:22 +0000 (UTC) Received: from pdx1-sub0-mail-a246.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 29B755422EF; Mon, 23 Oct 2023 16:40:22 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1698079222; a=rsa-sha256; cv=none; b=oyid555smlH5SAVxopOJPWrPBoK+oDSuCukmmOhVBd2Z0UUzWGskTvr1orkqas7hkbbpY8 /DozEGNs/xPFP+Ik1cGEG1Xj4zaQTchUXdolVVg5Mwr/c7okj8mnbdvBuOt+aVwv58NCNf VkvRKcx7K/C2CtzCTbUA1LnzMFtrVYYMiTBNYUGm4YDkR+YxXqD2ScNi5mEs1iHYArNwxV 00qjntNMvqkGe/N1F6Mk7z038LLpTV683zMqRpPWHUmZe9pMaol/+ADpHpx7EFrV9beknp sxa2oB2j86uWBL94z/0kZ/QFbWARCenRVs5ZMzouN4Onc9JapNY95wRwzd+a6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1698079222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CiQRexYr/R/tzTO/X3itk2R++DbYCwK+49fhv1PurVE=; b=ZenWJ4AvQLinvzFm82+muWYJVxaiZpyxmkC1rqrMsR5ABa6lvyqiPzNfs0Tva3u1bJIz6H 38Q0lNQtfBkcd+R5q1MjFCMIRG7pysK3xMx63gYoyc1ObLMGjeoXefEOqEgTNIT5C1XJGY K9Sp9gkwppPdTIR8Aw+4rJRW/rudrxMfDClYbGgmABaVU3Q0EZukzi0HFA+eHbyVJgKJdD uMa2He0IEQ61z2Xsr9ND1Wc9SbYu+d//MxFEG5f1k5ZxLADboguBUNDcUzuTBrL6QjcnyE y7asEuemGj/bGJylKztvc9Q7bHRB3205Z51BoWh52s0G7/sv7SnGx7bDl7WYqw== ARC-Authentication-Results: i=1; rspamd-6557c4b887-fsldj; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Supply-Language: 05882b297458d986_1698079222508_439407265 X-MC-Loop-Signature: 1698079222508:2216658518 X-MC-Ingress-Time: 1698079222508 Received: from pdx1-sub0-mail-a246.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.119.65.135 (trex/6.9.2); Mon, 23 Oct 2023 16:40:22 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a246.dreamhost.com (Postfix) with ESMTPSA id 4SDgsd3psQzDc; Mon, 23 Oct 2023 09:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1698079221; bh=CiQRexYr/R/tzTO/X3itk2R++DbYCwK+49fhv1PurVE=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=sepISr2ZBcl3N+h5kvtVEqZrjvUZ4qAUmOKKlO4BifMmXkdWdGhX1YTvm71cCcAUq 51cgwLf1EM2+K/X0WxsHXzVn4GIwJhOwwirvP+gtJxKpy7G9CGVNXTWOrFXZxsbEvB NALXWA/2IWX1EJT+8EUb5XCGLvrCz1gIUh83+MUUJSN3eui1PXYwcPjaPhJStYnGn1 a8617E8Ruyu4vb3L5Z60uxye2fEnD7jC1MBRvz91ryOORpA2MimVtEDyO9K48KCHpI xY9q3y+PpoIxkcSk1ZkUZD5DfZZWT+RKDQp/KW7mCNvjm48uLiVFPvVAoOByzO15V7 Xhf1eP3EmKbWw== Message-ID: Date: Mon, 23 Oct 2023 09:40:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] gcc: config: microblaze: fix cpu version check Content-Language: en-US To: Neal Frager , gcc-patches@gcc.gnu.org, eager@eagerm.com Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com References: <20231023054851.1205436-1-neal.frager@amd.com> From: Michael Eager In-Reply-To: <20231023054851.1205436-1-neal.frager@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/22/23 22:48, Neal Frager wrote: > There is a microblaze cpu version 10.0 included in versal. If the > minor version is only a single digit, then the version comparison > will fail as version 10.0 will appear as 100 compared to version > 6.00 or 8.30 which will calculate to values 600 and 830. > > The issue can be seen when using the '-mcpu=10.0' option. > > With this fix, versions with a single digit minor number such as > 10.0 will be calculated as greater than versions with a smaller > major version number, but with two minor version digits. > > By applying this fix, several incorrect warning messages will no > longer be printed when building the versal plm application, such > as the warning message below: > > warning: '-mxl-multiply-high' can be used only with '-mcpu=v6.00.a' or greater > > Signed-off-by: Neal Frager > --- > gcc/config/microblaze/microblaze.cc | 164 +++++++++++++--------------- > 1 file changed, 76 insertions(+), 88 deletions(-) Please add a test case. -- Michael Eager