From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 01C97385DC33 for ; Mon, 30 Nov 2020 01:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 01C97385DC33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-wDKO1wNLMqK1Se-nQQ_q_Q-1; Sun, 29 Nov 2020 20:14:19 -0500 X-MC-Unique: wDKO1wNLMqK1Se-nQQ_q_Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47F251842142; Mon, 30 Nov 2020 01:14:18 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-145.phx2.redhat.com [10.3.112.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16FAF60C5F; Mon, 30 Nov 2020 01:14:18 +0000 (UTC) Subject: Re: [PATCH] rtl_dump_bb: fix segfault when reporting internal error To: Ilya Leoshkevich , gcc-patches@gcc.gnu.org References: <20201126192425.284464-1-iii@linux.ibm.com> From: Jeff Law Message-ID: Date: Sun, 29 Nov 2020 18:14:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201126192425.284464-1-iii@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 01:14:23 -0000 On 11/26/20 12:24 PM, Ilya Leoshkevich via Gcc-patches wrote: > Bootstrapped and regtested on x86_64-redhat-linux and > s390x-redhat-linux. Ok for master? > > > > During ICE reporting, sometimes rtl_dump_bb is called on partially > initialized basic blocks. This produces another ICE, obscuring the > original problem. > > Fix by checking that that basic blocks are initialized before touching > their bb_infos. > > gcc/ChangeLog: > > 2020-11-25 Ilya Leoshkevich > > * cfgrtl.c (rtl_bb_info_initialized_p): New function. > (rtl_dump_bb): Use rtl_bb_info_initialized_p before accessing bb > insns. I think reality is that these routines are never going to be 100% safe in terms of not ICEing themselves (after all, the ICE might be an internal inconsistency in the RTL IL itself), this seems like a reasonable amount of sanity checking. OK. jeff