From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66830 invoked by alias); 17 Jul 2019 08:46:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66821 invoked by uid 89); 17 Jul 2019 08:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jul 2019 08:46:33 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 83298AEBB; Wed, 17 Jul 2019 08:46:31 +0000 (UTC) Subject: Re: [PATCH v4] Generalize get_most_common_single_value to return k_th value & count To: luoxhu , gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz, segher@kernel.crashing.org, wschmidt@linux.ibm.com References: <20190715082043.24541-1-luoxhu@linux.ibm.com> <622d5e32-f430-2b07-2902-463f8770e984@suse.cz> <7e334738-324f-1e0d-b368-ac4ce1d9869c@suse.cz> <5d895099-ed2a-66ab-23a7-67c81f8bea9e@linux.ibm.com> <6c388a29-f9fb-9865-18bd-50faabd4f8cf@foxlink.cz> <12290ad8-9c1a-c729-53c4-a1df34bc9e01@linux.ibm.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Wed, 17 Jul 2019 09:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <12290ad8-9c1a-c729-53c4-a1df34bc9e01@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg01158.txt.bz2 On 7/17/19 10:44 AM, luoxhu wrote: > Hi Martin, > > On 2019/7/17 15:55, Martin Liška wrote: >> On 7/17/19 7:44 AM, luoxhu wrote: >>> Hi Martin, >>> Thanks for your review, v4 Changes as below: >>>   1. Use decrease bubble sort. >>> BTW, I have a question about hist->hvalue.counters[2], when will it become >>>   -1, please? Thanks.  Currently, if it is -1, the function will return false. >> >> Hi. >> >> Thanks for that. I made a minor changes to your patch, please see it in attachment. >> -1 is a value that we use for invalidated histogram. That happens when you need >> to fit in more values during instrumentation than you have counters in the histogram. >> It helps to make reproducible builds of a software. > Thanks for your patience with many tiny fixes.  I will install the updated > patch to trunk. Please wait for an approval of a maintainer, I'm not one of them ;) Thanks, Martin > > Xionghu > >> >> Martin >> >