public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@acm.org>
To: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Using decls
Date: Tue, 21 May 2019 14:47:00 -0000	[thread overview]
Message-ID: <d7df0f17-1987-c0ec-8536-b5adbc9c5948@acm.org> (raw)
In-Reply-To: <20190521144355.GO7979@redhat.com>

On 5/21/19 10:43 AM, Marek Polacek wrote:
> Thanks for the patch and sorry for nitpicking:
> 
> On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote:
>> -/* Process a local-scope or namespace-scope using declaration.  SCOPE
>> +/* Process a local-scope or namespace-scope using declaration.
>> +   FIXME
> 
> This ain't look right.  You meant to document the INSERT_P param, right.

Yes indeed.  Found these when merging back to modules.  Thanks for noticing!


-- 
Nathan Sidwell

  reply	other threads:[~2019-05-21 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 14:32 Nathan Sidwell
2019-05-21 14:44 ` Marek Polacek
2019-05-21 14:47   ` Nathan Sidwell [this message]
2019-05-21 15:30   ` Nathan Sidwell
  -- strict thread matches above, loose matches on Subject: below --
2017-05-23 11:07 [C++ PATCH] using decls Nathan Sidwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7df0f17-1987-c0ec-8536-b5adbc9c5948@acm.org \
    --to=nathan@acm.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).