From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40533 invoked by alias); 21 May 2019 14:47:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40521 invoked by uid 89); 21 May 2019 14:47:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:510 X-HELO: mail-qk1-f172.google.com Received: from mail-qk1-f172.google.com (HELO mail-qk1-f172.google.com) (209.85.222.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 14:47:00 +0000 Received: by mail-qk1-f172.google.com with SMTP id q197so11201550qke.7 for ; Tue, 21 May 2019 07:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3bHcwPPqdQGpeRkg3lUAMymKAWU4JsKzxiSQUBLMTyg=; b=lkMrkm4f+eBI4MbiPAIcEJ8aVwGr0iObS3SrVbGc5gBkmkMlwikmXRWl93nLo8mVCS AZ7zCKdpMm5ED/gaCitOS1L9zSTTMhkBkcSgV1XfAYDNqFyrxQG4XI4RhpMYZ3JYUNeH cqdnxHiJPTTZkPBgTow2vAlNmCd0Le0+a9eNQuCMjQvHyrqJgsxsu9lotKLHZ2iza+4U B1N0XMSVYCYMYP/KYJBuV0A/gs5Pfz1zU4ClYjTXsIQDm6zaKuHvXWHcvTXIBwFesFzp H57qi4AoM7Bktkq0YdUkwsCTlNhc/hd4i1bau9Oj9IHTaCqX9DXKmvxXG4hmmhMgUZWf 00WA== Return-Path: Received: from ?IPv6:2620:10d:c0a3:1407:6077:ec57:6cfa:c95c? ([2620:10d:c091:500::3:8245]) by smtp.googlemail.com with ESMTPSA id t17sm13242795qte.66.2019.05.21.07.46.58 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 07:46:58 -0700 (PDT) Subject: Re: [C++ PATCH] Using decls To: gcc-patches@gcc.gnu.org References: <328937e0-531e-a7be-3151-e3a622be0efa@acm.org> <20190521144355.GO7979@redhat.com> From: Nathan Sidwell Message-ID: Date: Tue, 21 May 2019 14:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190521144355.GO7979@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg01400.txt.bz2 On 5/21/19 10:43 AM, Marek Polacek wrote: > Thanks for the patch and sorry for nitpicking: > > On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: >> -/* Process a local-scope or namespace-scope using declaration. SCOPE >> +/* Process a local-scope or namespace-scope using declaration. >> + FIXME > > This ain't look right. You meant to document the INSERT_P param, right. Yes indeed. Found these when merging back to modules. Thanks for noticing! -- Nathan Sidwell