From: Martin Sebor <msebor@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 10/13] v2 Use new per-location warning APIs in the middle end
Date: Thu, 24 Jun 2021 19:40:02 -0600 [thread overview]
Message-ID: <d7e12c4b-e83a-87f8-e600-cf30fc79ea69@gmail.com> (raw)
In-Reply-To: <4ff717be-bcc2-7c74-61cc-1c5a088a437e@gmail.com>
On 6/23/21 11:15 PM, Jeff Law wrote:
>
>
> On 6/4/2021 3:43 PM, Martin Sebor via Gcc-patches wrote:
>> The attached patch introduces declarations of the new
>> suppress_warning(), warning_suppressed_p(), and copy_warning() APIs,
>> and replaces the uses of TREE_NO_WARNING in the middle end with them.
>>
>> gcc-no-warning-middle-end.diff
>>
>> Add support for per-location warning groups.
>>
>> gcc/ChangeLog:
>>
>> * builtins.c (warn_string_no_nul): Replace uses of TREE_NO_WARNING,
>> gimple_no_warning_p and gimple_set_no_warning with
>> warning_suppressed_p, and suppress_warning.
>> (c_strlen): Same.
>> (maybe_warn_for_bound): Same.
>> (warn_for_access): Same.
>> (check_access): Same.
>> (expand_builtin_strncmp): Same.
>> (fold_builtin_varargs): Same.
>> * calls.c (maybe_warn_nonstring_arg): Same.
>> (maybe_warn_rdwr_sizes): Same.
>> * cfgexpand.c (expand_call_stmt): Same.
>> * cgraphunit.c (check_global_declaration): Same.
>> * fold-const.c (fold_undefer_overflow_warnings): Same.
>> (fold_truth_not_expr): Same.
>> (fold_unary_loc): Same.
>> (fold_checksum_tree): Same.
>> * gengtype.c (open_base_files): Same.
>> * gimple-array-bounds.cc (array_bounds_checker::check_array_ref): Same.
>> (array_bounds_checker::check_mem_ref): Same.
>> (array_bounds_checker::check_addr_expr): Same.
>> (array_bounds_checker::check_array_bounds): Same.
>> * gimple-expr.c (copy_var_decl): Same.
>> * gimple-fold.c (gimple_fold_builtin_strcpy): Same.
>> (gimple_fold_builtin_strncat): Same.
>> (gimple_fold_builtin_stxcpy_chk): Same.
>> (gimple_fold_builtin_stpcpy): Same.
>> (gimple_fold_builtin_sprintf): Same.
>> (fold_stmt_1): Same.
>> * gimple-ssa-isolate-paths.c (diag_returned_locals): Same.
>> * gimple-ssa-nonnull-compare.c (do_warn_nonnull_compare): Same.
>> * gimple-ssa-sprintf.c (handle_printf_call): Same.
>> * gimple-ssa-store-merging.c (imm_store_chain_info::output_merged_store): Same.
>> * gimple-ssa-warn-restrict.c (maybe_diag_overlap): Same.
>> (maybe_diag_access_bounds): Same.
>> (check_call): Same.
>> (check_bounds_or_overlap): Same.
>> * gimple.c (gimple_build_call_from_tree): Same.
>> * gimplify.c (gimplify_return_expr): Same.
>> (gimplify_cond_expr): Same.
>> (gimplify_modify_expr_complex_part): Same.
>> (gimplify_modify_expr): Same.
>> (gimple_push_cleanup): Same.
>> (gimplify_expr): Same.
>> * omp-expand.c (expand_omp_for_generic): Same.
>> (expand_omp_taskloop_for_outer): Same.
>> * omp-low.c (lower_rec_input_clauses): Same.
>> (lower_lastprivate_clauses): Same.
>> (lower_send_clauses): Same.
>> (lower_omp_target): Same.
>> * tree-cfg.c (pass_warn_function_return::execute): Same.
>> * tree-complex.c (create_one_component_var): Same.
>> * tree-inline.c (remap_gimple_op_r): Same.
>> (copy_tree_body_r): Same.
>> (declare_return_variable): Same.
>> (expand_call_inline): Same.
>> * tree-nested.c (lookup_field_for_decl): Same.
>> * tree-sra.c (create_access_replacement): Same.
>> (generate_subtree_copies): Same.
>> * tree-ssa-ccp.c (pass_post_ipa_warn::execute): Same.
>> * tree-ssa-forwprop.c (combine_cond_expr_cond): Same.
>> * tree-ssa-loop-ch.c (ch_base::copy_headers): Same.
>> * tree-ssa-loop-im.c (execute_sm): Same.
>> * tree-ssa-phiopt.c (cond_store_replacement): Same.
>> * tree-ssa-strlen.c (maybe_warn_overflow): Same.
>> (handle_builtin_strcpy): Same.
>> (maybe_diag_stxncpy_trunc): Same.
>> (handle_builtin_stxncpy_strncat): Same.
>> (handle_builtin_strcat): Same.
>> * tree-ssa-uninit.c (get_no_uninit_warning): Same.
>> (set_no_uninit_warning): Same.
>> (uninit_undefined_value_p): Same.
>> (warn_uninit): Same.
>> (maybe_warn_operand): Same.
>> * tree-vrp.c (compare_values_warnv): Same.
>> * vr-values.c (vr_values::extract_range_for_var_from_comparison_expr): Same.
>> (test_for_singularity): Same.
>>
>> * gimple.h (warning_suppressed_p): New function.
>> (suppress_warning): Same.
>> (copy_no_warning): Same.
>> (gimple_set_block): Call gimple_set_location.
>> (gimple_set_location): Call copy_warning.
>> * tree.h (no_warning, all_warnings): New constants.
>> (warning_suppressed_p): New function.
>> (suppress_warning): Same.
>> (copy_no_warning): Same.
> OK once prereqs are approved.
>
> jeff
>
Retested on top patch 1 plus the C and C++ bits and pushed r12-1805.
I'll do the rest of the approved patches tomorrow.
Martin
next prev parent reply other threads:[~2021-06-25 1:40 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 22:02 [PATCH 0/11] warning control by group and location (PR 74765) Martin Sebor
2021-05-24 22:07 ` [PATCH 1/11] introduce xxx_no_warning APIs Martin Sebor
2021-05-24 22:09 ` [PATCH 2/11] use xxx_no_warning APIs in Ada Martin Sebor
2021-05-25 8:59 ` Eric Botcazou
2021-05-27 20:29 ` Martin Sebor
2021-05-24 22:10 ` [PATCH 3/11] use xxx_no_warning APIs in C Martin Sebor
2021-05-24 22:11 ` [PATCH 4/11] use xxx_no_warning APIs in C family Martin Sebor
2021-05-24 22:11 ` [PATCH 5/11] use xxx_no_warning APIs in C++ Martin Sebor
2021-05-24 22:12 ` [PATCH 6/11] use xxx_no_warning APIs in Fortran Martin Sebor
2021-05-24 22:13 ` [PATCH 7/11] " Martin Sebor
2021-05-24 22:14 ` [PATCH 8/11] use xxx_no_warning APIs in Objective-C Martin Sebor
2021-05-25 14:01 ` Iain Sandoe
2021-05-25 15:48 ` Martin Sebor
2021-05-25 15:56 ` Iain Sandoe
2021-05-24 22:15 ` [PATCH 9/11] use xxx_no_warning APIs in rl78 back end Martin Sebor
2021-05-24 22:16 ` [PATCH 10/11] use xxx_no_warning APIs in libcc1 Martin Sebor
2021-05-24 22:16 ` [PATCH 11/11] use xxx_no_warning APIs in the middle end Martin Sebor
2021-05-24 23:08 ` David Malcolm
2021-05-25 0:44 ` Martin Sebor
2021-05-24 23:08 ` [PATCH 0/11] warning control by group and location (PR 74765) David Malcolm
2021-05-25 0:42 ` Martin Sebor
2021-05-25 9:04 ` Richard Biener
2021-05-25 20:50 ` Martin Sebor
2021-05-27 11:19 ` Richard Sandiford
2021-05-27 16:41 ` Martin Sebor
2021-05-27 21:55 ` David Malcolm
2021-05-28 4:40 ` Jason Merrill
2021-06-04 21:27 ` [PATCH 0/13] v2 " Martin Sebor
2021-06-04 21:41 ` [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups " Martin Sebor
2021-06-21 21:34 ` [PING][PATCH " Martin Sebor
2021-06-22 23:18 ` [PATCH " David Malcolm
2021-06-22 23:28 ` David Malcolm
2021-06-23 19:47 ` Martin Sebor
2021-06-24 5:26 ` Jeff Law
2021-06-25 1:34 ` Martin Sebor
2021-09-01 19:35 ` Thomas Schwinge
2021-09-02 0:14 ` Martin Sebor
2021-09-03 19:16 ` Thomas Schwinge
2021-09-10 7:45 ` [PING] Don't maintain a warning spec for 'UNKNOWN_LOCATION'/'BUILTINS_LOCATION' [PR101574] (was: [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups (PR 74765)) Thomas Schwinge
2021-09-13 14:00 ` Jeff Law
2021-11-09 14:18 ` Use 'location_hash' for 'gcc/diagnostic-spec.h:nowarn_map' " Thomas Schwinge
2021-11-15 15:01 ` [ping] Use 'location_hash' for 'gcc/diagnostic-spec.h:nowarn_map' Thomas Schwinge
2021-11-15 16:43 ` Martin Sebor
2021-11-09 10:28 ` Get rid of infinite recursion for 'typedef' used with GTY-marked 'gcc/diagnostic-spec.h:nowarn_map' [PR101204] (was: [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups (PR 74765)) Thomas Schwinge
2021-11-09 10:54 ` Richard Biener
2021-11-09 12:25 ` Get rid of infinite recursion for 'typedef' used with GTY-marked 'gcc/diagnostic-spec.h:nowarn_map' [PR101204, PR103157] Thomas Schwinge
2021-11-10 4:52 ` Get rid of infinite recursion for 'typedef' used with GTY-marked 'gcc/diagnostic-spec.h:nowarn_map' [PR101204] Martin Sebor
2021-11-24 10:28 ` 'gengtype' (was: Get rid of infinite recursion for 'typedef' used with GTY-marked 'gcc/diagnostic-spec.h:nowarn_map' [PR101204]) Thomas Schwinge
2021-06-04 21:41 ` [PATCH 2/13] v2 Use new per-location warning APIs in Ada Martin Sebor
2021-06-24 5:07 ` Jeff Law
2021-06-28 21:20 ` Martin Sebor
2021-06-04 21:41 ` [PATCH 3/13] v2 Use new per-location warning APIs in C front end Martin Sebor
2021-06-21 21:35 ` [PING][PATCH " Martin Sebor
2021-06-24 5:09 ` [PATCH " Jeff Law
2021-06-25 1:35 ` Martin Sebor
2021-06-04 21:42 ` [PATCH 4/13] v2 Use new per-location warning APIs in C family code Martin Sebor
2021-06-21 21:35 ` [PING][PATCH " Martin Sebor
2021-06-24 5:06 ` [PATCH " Jeff Law
2021-06-25 1:36 ` Martin Sebor
2021-06-04 21:42 ` [PATCH 5/13] v2 Use new per-location warning APIs in the RL78 back end Martin Sebor
2021-06-24 5:06 ` Jeff Law
2021-06-04 21:42 ` [PATCH 6/13] v2 Use new per-location warning APIs in the C++ front end Martin Sebor
2021-06-21 21:37 ` [PING][PATCH " Martin Sebor
2021-06-24 5:12 ` [PATCH " Jeff Law
2021-06-25 1:38 ` Martin Sebor
2021-06-04 21:42 ` [PATCH 7/13] v2 Use new per-location warning APIs in the FORTRAN " Martin Sebor
2021-06-21 21:42 ` [PING][PATCH " Martin Sebor
2021-06-24 5:05 ` [PATCH " Jeff Law
2021-06-28 21:21 ` Martin Sebor
2021-06-04 21:42 ` [PATCH 8/13] v2 Use new per-location warning APIs in libcc1 Martin Sebor
2021-06-24 5:04 ` Jeff Law
2021-06-28 21:22 ` Martin Sebor
2021-06-04 21:43 ` [PATCH 9/13] v2 Use new per-location warning APIs in LTO Martin Sebor
2021-06-21 21:54 ` [PING][PATCH " Martin Sebor
2021-06-24 9:32 ` Richard Biener
2021-06-24 15:27 ` Martin Sebor
2021-06-25 7:46 ` Richard Biener
2021-06-24 5:03 ` [PATCH " Jeff Law
2021-06-04 21:43 ` [PATCH 10/13] v2 Use new per-location warning APIs in the middle end Martin Sebor
2021-06-21 21:58 ` [PING][PATCH " Martin Sebor
2021-06-24 5:15 ` [PATCH " Jeff Law
2021-06-25 1:40 ` Martin Sebor [this message]
2021-06-04 21:43 ` [PATCH 11/13] v2 Use new per-location warning APIs in the Objective-C front end Martin Sebor
2021-06-24 5:02 ` Jeff Law
2021-06-28 21:22 ` Martin Sebor
2021-06-04 21:43 ` [PATCH 12/13] v2 Remove TREE_NO_WARNING and gimple*no_warning* APIs Martin Sebor
2021-06-24 5:01 ` Jeff Law
2021-06-04 21:43 ` [PATCH 13/13] v2 Add regression tests for PR 74765 and 74762 Martin Sebor
2021-06-24 4:56 ` Jeff Law
2021-06-28 21:23 ` Martin Sebor
2021-06-15 1:29 ` [PING][PATCH 0/13] v2 warning control by group and location (PR 74765) Martin Sebor
2021-07-17 20:36 ` [PATCH " Jan-Benedict Glaw
2021-07-19 15:08 ` Martin Sebor
2021-07-28 11:14 ` Andrew Burgess
2021-07-28 16:16 ` Martin Sebor
2021-07-29 8:26 ` Andrew Burgess
2021-07-29 14:41 ` Martin Sebor
2021-05-30 2:06 ` [PATCH 0/11] " Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7e12c4b-e83a-87f8-e600-cf30fc79ea69@gmail.com \
--to=msebor@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).