From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 452963858D39 for ; Wed, 24 May 2023 18:18:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 452963858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-64d293746e0so1384045b3a.2 for ; Wed, 24 May 2023 11:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1684952318; x=1687544318; h=content-transfer-encoding:in-reply-to:cc:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ThenYHDEg+3yMFMNbPZlHk7rYHzB97bHsamSCcAQVDE=; b=pKQgjiUZ5wghhUJBG4qD5iV0HIPzXF7A5WvqSVeAHyIYwoNRB9P238s7WprrGVn470 RR1h9A5YEsz1mXb/TZ9yfFpkJRrBXWFBSi94FfxQXFLHe6sOXR+RKALLsgW64rPOqhB7 6yixosUyi9MmuFJI6h+Hs/wHRauRlNwjrrVW/WQv+48A/Vvtft18bFs9B5N+LDVF5Td/ qOPXEnBeGZaZoIZ8Gg5QxLrOz6n7ckZjmwNq81akew/cQA1Z3YXy6ajz6MF2p4DYlF2/ BXQ7ma2JofgQrkLQJAtNknawxzeqxTI/+8veZJVZa5QPCLgFjpuyFk5sXaNx0cO6Uk+C aWfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684952318; x=1687544318; h=content-transfer-encoding:in-reply-to:cc:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ThenYHDEg+3yMFMNbPZlHk7rYHzB97bHsamSCcAQVDE=; b=FbFHWJew/7i7Ef7dnYGB1LTsPMfJlASNT8gTgQKpEdnLWFBF9pyUF/mtY5McDJTns3 ZlhEie76k99P20f+e1puH9jyW/SHytIgLOShMNLeINDW6iIN+Bo7Rtz4jP5HDDQnvkMA 3MkTm4zpgSg7b2PfIWM30U3h1klRGwlLs6YRagADWTQzmTDdoXb86vkd2gn+LQ/DVVKy fkdP+7P2veTzaZTjaJAFZ0EY9QLzjTgltoT4AzeWPRdYufWgccX/fQ8Z1eKMAKiANPRE kh+5VgOsu6EouRZYFDUn3v9tM7tj1uywv9Xx8oV5zDnxnAft8Egh2X6hLlIFDDfz/j5w 306w== X-Gm-Message-State: AC+VfDye4EgCANTh/U30LSfFZ9gIkE+uCRNmuR8avBhEBoW2cXuV6rrL 2itvJnzbfUU5meDVspk0aWxApQ== X-Google-Smtp-Source: ACHHUZ6VtnZFVr7m2FNpsW7d0NdNbKvy/3BsgvmNj2HpXJeG6Kfkbe/BTGJ85MFIzzmwa71Qoiwh7g== X-Received: by 2002:a05:6a20:4e11:b0:10c:4e7f:1a53 with SMTP id gk17-20020a056a204e1100b0010c4e7f1a53mr6632081pzb.62.1684952317922; Wed, 24 May 2023 11:18:37 -0700 (PDT) Received: from [192.168.50.116] ([71.202.114.183]) by smtp.gmail.com with ESMTPSA id w5-20020a63c105000000b0053ba9ddbb62sm4840236pgf.91.2023.05.24.11.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 11:18:37 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 11:18:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] RISC-V: Add missing torture-init and torture-finish for rvv.exp Content-Language: en-US From: Vineet Gupta To: Kito Cheng , gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, patrick@rivosinc.com, jlaw@ventanamicro.com References: <20230522064138.74056-1-kito.cheng@sifive.com> Cc: Thomas Schwinge , "Maciej W . Rozycki" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,LIKELY_SPAM_BODY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: +CC Thomas and Maciej On 5/22/23 20:52, Vineet Gupta wrote: > On 5/22/23 02:17, Kito Cheng wrote: >> Ooops, seems still some issue around here, > > Yep still 5000 fails :-( > >>   but I found something might >> related this issue: >> >> https://github.com/gcc-mirror/gcc/commit/d6654a4be3ba44c0d57be7c8a51d76d9721345e1 >> >> https://github.com/gcc-mirror/gcc/commit/23c49bb8d09bc3bfce9a08be637cf32ac014de56 >> > > It seems both of these patches are essentially doing what yours did. > So something else is amiss still. Apparently in addition to Kito's patch below, If I comment out the additional torture options, failures go down drastically. diff --git a/gcc/testsuite/gcc.target/riscv/riscv.exp b/gcc/testsuite/gcc.target/riscv/riscv.exp -lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} +#lappend ADDITIONAL_TORTURE_OPTIONS {-Og -g} {-Oz} @Thomas, do you have some thoughts on how to fix riscv.exp properly in light of recent changes to exp files. > > Thx, > -Vineet > >> >> On Mon, May 22, 2023 at 2:42 PM Kito Cheng >> wrote: >>> Hi Vineet: >>> >>> Could you help to test this patch, this could resolve that issue on our >>> machine, but I would like to also work for other env. >>> >>> Thanks :) >>> >>> --- >>> >>> We got bunch of following error message for multi-lib run: >>> >>> ERROR: torture-init: torture_without_loops is not empty as expected >>> ERROR: tcl error code NONE >>> >>> And seems we need torture-init and torture-finish around the test >>> loop. >>> >>> gcc/testsuite/ChangeLog: >>> >>>          * gcc.target/riscv/rvv/rvv.exp: Add torture-init and >>>          torture-finish. >>> --- >>>   gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 3 +++ >>>   1 file changed, 3 insertions(+) >>> >>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>> index bc99cc0c3cf4..19179564361a 100644 >>> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp >>> @@ -39,6 +39,7 @@ if [istarget riscv32-*-*] then { >>> >>>   # Initialize `dg'. >>>   dg-init >>> +torture-init >>> >>>   # Main loop. >>>   set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3" >>> @@ -69,5 +70,7 @@ foreach op $AUTOVEC_TEST_OPTS { >>>   dg-runtest [lsort [glob -nocomplain >>> $srcdir/$subdir/autovec/vls-vlmax/*.\[cS\]]] \ >>>          "-std=c99 -O3 -ftree-vectorize --param >>> riscv-autovec-preference=fixed-vlmax" $CFLAGS >>> >>> +torture-finish >>> + >>>   # All done. >>>   dg-finish >>> -- >>> 2.40.1 >>> >