From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id B161F3858D37 for ; Tue, 27 Dec 2022 17:35:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B161F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x133.google.com with SMTP id d14so7014392ilq.11 for ; Tue, 27 Dec 2022 09:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FVPbp+EyudLd1mhfcHk0nTUVAxWXIMDBHSSdkIPyjOs=; b=WAG8/ntQuLlriq7UVpu9KQ4UkI7LKqgiTd6qzCRObqFy8ysZ8re09mBPAaSDiS2qZd EZM5r/xIKGnNCc/7rXd/ab2iSAb4OoPeTgzdisldOXej2wQQPbz4IKzwdm2a8sltIazb RtayhM9jRgM1UDA30EjZHfzCpz35bQCbbjW2yQKJ1xSVIVdiRxqTaaM34g/JNMM1tF23 hpVBE2DgtvMXHbnNT40ZzmgJ6n2tN1ayHzL2D0eat0Nhu4WNFJRySIGaPfOfRRudzo9q +JL2M02D1q59jS8K/yk4OM/G+fB87RVuJuYmgTEDxs29/K9KmaW8o+/sIHVh7XBu2OFG 3VBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FVPbp+EyudLd1mhfcHk0nTUVAxWXIMDBHSSdkIPyjOs=; b=skeYwxytYc4XRMUCRuxFBasVUg13V19wAORfXPFU1x05niEgqDqmYhEE3X1CZ2iQGR xNa+9v+COcBEiTk8VFqpGWF7h8tJyRRHNSjwE8f22qVO5LjD005rXXhOrEV7suspVivC eUM+eNkl1iMPp0CNF1oAskIkDpGLCva27ccDYNeFnArtzcZ3BaTvauuDOTHNks9Mv5nP 3XlfE4WqlDTd8AHb2x0E3QcwTNRRAYGfh80b9Zb1qq6l0GHBNyXZkTOOa0ShhJIaBn3g yv7y5d/vO/NwvxZFY8kOcTOVTzFPoCXi1c1xcyaL+7oqfZ73d9slsVE3XfMvFDuNBWe3 fVTg== X-Gm-Message-State: AFqh2krEZkOSgxWNGPZXMAu9BFP7HjwJUH6l0ADfV1/xyJGv+qFF2g0y 7oeSqwsbpSoaLmQKiVymLS8= X-Google-Smtp-Source: AMrXdXtudFTbsG9vDdcsOul89CMrru3HQLcIUzRNng5+HGyum5JzrZwYAExbdHljt5kGatkmSCLSdw== X-Received: by 2002:a05:6e02:1d99:b0:30b:d861:2c84 with SMTP id h25-20020a056e021d9900b0030bd8612c84mr20008431ila.0.1672162557888; Tue, 27 Dec 2022 09:35:57 -0800 (PST) Received: from [172.31.1.18] (65-130-81-249.slkc.qwest.net. [65.130.81.249]) by smtp.gmail.com with ESMTPSA id t24-20020a02b198000000b0038a41eb1ba3sm4402921jah.177.2022.12.27.09.35.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 09:35:57 -0800 (PST) Message-ID: Date: Tue, 27 Dec 2022 10:35:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH] RISC-V: Add support for vector crypto extensions Content-Language: en-US To: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Aaron Durbin , Vineet Gupta , Andrew de los Reyes , Eric Gouriou , Barna Ibrahim References: <20221221183103.3800844-1-christoph.muellner@vrull.eu> From: Jeff Law In-Reply-To: <20221221183103.3800844-1-christoph.muellner@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_MANYTO,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/21/22 11:31, Christoph Muellner wrote: > From: Christoph Müllner > > This series adds basic support for the vector crypto extensions: > * Zvkb > * Zvkg > * Zvkh[a,b] > * Zvkn > * Zvksed > * Zvksh > > The implementation follows the version 20221220 of the specification, > which can be found here: > https://github.com/riscv/riscv-crypto/releases/tag/v20221220 > > Note, that this specification is not frozen yet, meaning that > incompatible changes are possible. > Therefore, this patchset is marked as RFC and should not be considered > for upstream inclusion. > > All extensions come with (passing) tests for the feature test macros. > > A Binutils patch series for vector crypto support can be found here: > https://sourceware.org/pipermail/binutils/2022-December/125272.html > > Signed-off-by: Christoph Müllner > --- > gcc/common/config/riscv/riscv-common.cc | 16 ++++++++++++++++ > gcc/config/riscv/riscv-opts.h | 16 ++++++++++++++++ > gcc/config/riscv/riscv.opt | 3 +++ > gcc/testsuite/gcc.target/riscv/zvkb.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvkg.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvkha.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvkhb.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvkn.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvksed.c | 13 +++++++++++++ > gcc/testsuite/gcc.target/riscv/zvksh.c | 13 +++++++++++++ > 10 files changed, 126 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/riscv/zvkb.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvkg.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvkha.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvkhb.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvkn.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvksed.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zvksh.c I don't see anything objectionable in here. I'd guess that most (but perhaps not all) of these will wire up as builtins at some point in the not too distant future. Jeff