From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125644 invoked by alias); 15 Dec 2016 12:41:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125607 invoked by uid 89); 15 Dec 2016 12:41:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*F:U*nathan X-HELO: mail-yw0-f195.google.com Received: from mail-yw0-f195.google.com (HELO mail-yw0-f195.google.com) (209.85.161.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Dec 2016 12:41:01 +0000 Received: by mail-yw0-f195.google.com with SMTP id s68so1508173ywg.0 for ; Thu, 15 Dec 2016 04:41:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=MsjTYN5ZDLufgC6ZicRT5H5cu2aCLKvG/BgiPZdNYAQ=; b=SKUHr9/l7uhfRJXybT83Jq3yk5o2DuRpvngN8JIsKvL5gVYdDgEkxb0Ebwkc6Uqppj /R9krwRZAek+YhmbfsSzT+54dUX5W/VAAvoidw/lHVx9Iq4hhXnMHdvg/f2qJ4UvG/qV qct6cFXBPaEl/dmdqMEsyL+fRhP/dQcUOzP7T89Cs6U17HfKGiyE6SpqJJ6A3LJQNh8p wHQq93OAASntYihosxovf7288if0JHP3jNRJ9zpLlIx7JhONsIuw8KCT6l4GsNdUQfh2 FnpjoPL113SPgA7m6P6C75znVVctzH1//EikcSJcDU10QTYrgq3z3OJVz5v74Hxtkdaw MvtA== X-Gm-Message-State: AKaTC03yC905sVHlz6Jt+ZLKgXFZcTmcV5gA0l8MPnNIk0D+GsmpkuNRPoYr0NHFTrgwHg== X-Received: by 10.129.145.85 with SMTP id i82mr893104ywg.263.1481805659868; Thu, 15 Dec 2016 04:40:59 -0800 (PST) Received: from ?IPv6:2620:10d:c0a3:20fb:f6d0:5ac5:64cd:f102? ([2620:10d:c091:200::640]) by smtp.googlemail.com with ESMTPSA id d131sm494123ywe.35.2016.12.15.04.40.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2016 04:40:59 -0800 (PST) Subject: Re: C++ Patch Ping To: Jakub Jelinek References: <20161215083414.GB21933@tucnak> <45d11afa-ead4-e605-ae04-9c4b8731289d@acm.org> <20161215122614.GG21933@tucnak> Cc: Jason Merrill , gcc-patches@gcc.gnu.org From: Nathan Sidwell Message-ID: Date: Thu, 15 Dec 2016 12:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161215122614.GG21933@tucnak> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg01363.txt.bz2 On 12/15/2016 07:26 AM, Jakub Jelinek wrote: > I don't think so. complete_type (error_mark_node) returns error_mark_node, > and COMPLETE_TYPE_P (error_mark_node) is invalid (should fail TYPE_CHECK in > checking compiler). > > I can write it as > inst = complete_type (inst); > if (inst == error_mark_node || !COMPLETE_TYPE_P (inst)) > return NULL_TREE; that's probably better, because complete_type can return error_mark_node if 'something goes horribly wrong' -- Nathan Sidwell