public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Joern Rennecke <joern.rennecke@embecosm.com>
Cc: Vineet Gupta <vineetg@rivosinc.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns)
Date: Thu, 9 Nov 2023 23:02:21 -0700	[thread overview]
Message-ID: <d816f693-bc51-4efd-8d24-7bcef673a8b0@gmail.com> (raw)
In-Reply-To: <CAMqJFCohe0qW4BGjbXSvBauJeAzkqoNNbSU+rCZV-jJgo+uAKg@mail.gmail.com>



On 11/8/23 09:00, Joern Rennecke wrote:
> On Fri, 29 Sept 2023 at 14:54, Jeff Law<jeffreyalaw@gmail.com>  wrote:
>> ...  Joern  can you post a follow-up manual twiddle so
>> that other ports can follow your example and avoid this problem?
>>
>> THanks,
>>
>> jeff
> The attached patch makes the scan-assembler* directives ignore the LTO
> sections.
> 
> Regression tested (using QEMU) for
>      riscv-sim
>      riscv-sim/-march=rv32gcv_zfh/-mabi=ilp32d/-ftree-vectorize/--param=riscv-autovec-preference=scalable
>      riscv-sim/-march=rv32imac/-mabi=ilp32
>      riscv-sim/-march=rv64gcv_zfh_zvfh_zba_zbb_zbc_zicond_zicboz_zawrs/-mabi=lp64d/-ftree-vectorize/--param=riscv-autovec-preference=scalable
>      riscv-sim/-march=rv64imac/-mabi=lp64
> 
> 
> scanasm-diff-5.txt
> 
> 2023-11-08  Joern Rennecke<joern.rennecke@embecosm.com>
> 
> gcc/testsuite/
> 	* lib/scanasm.exp (scan-assembler-times): Disregard LTO sections.
> 	(scan-assembler-dem, scan-assembler-dem-not): Likewise.
> 	(dg-scan): Likewise, if name starts with scan-assembler.
> 	(scan-raw-assembler): New proc.
> 	* gcc.dg/pr61868.c: Use scan-raw-assembler.
> 	* gcc.dg/scantest-lto.c: New test.
> gcc/
> 	* doc/sourcebuild.texi (Scan the assembly output): Document change.
Looks reasonable to me. OK for the trunk.
jeff

      reply	other threads:[~2023-11-10  6:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  9:26 committed [RISC-V]: Harden test scan patterns Joern Rennecke
2023-09-27 17:22 ` Jeff Law
2023-09-27 18:22   ` Joern Rennecke
2023-09-27 20:14     ` Jeff Law
2023-09-27 22:12       ` Andrew Pinski
2023-09-27 23:21       ` Vineet Gupta
2023-09-29 13:54         ` Jeff Law
2023-09-30 21:12           ` Joern Rennecke
2023-10-11  4:48             ` Joern Rennecke
2023-10-11  7:12               ` Joern Rennecke
2023-11-08 15:14               ` Joern Rennecke
2023-11-08 16:00           ` RFA: make scan-assembler* ignore LTO sections (Was: Re: committed [RISC-V]: Harden test scan patterns) Joern Rennecke
2023-11-10  6:02             ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d816f693-bc51-4efd-8d24-7bcef673a8b0@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joern.rennecke@embecosm.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).