From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 136A43857BB2 for ; Sun, 21 Jan 2024 22:53:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 136A43857BB2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 136A43857BB2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705877582; cv=none; b=I6IEL8eDk6sh4FOyd+a2qK7dnAHvLFDwe9SKFCUfVhe6PvsRZVv96EHASS3OxgZb/oBWL82KWdC9eRvcOHTeIhUbBuMub97Pig+XvOWjQjLS47oWbHWqghMpIEKqASaCmFtExU707l41qje09fyIGHP99Y6u+Ibdfp6vMNMjG0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705877582; c=relaxed/simple; bh=r0MUJ3gYsd98p06+RbjJlvuTyWEk7ahPBROHmBdAX7k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qMq08686ceqC/UfEL1ipy0A//6K/1z2+J2k7i9gueMI+9taC9QFabvvCYllNDMlcbpyfALZQCboXKVUxAssYt/CAr+AVvqIq8hi/KR1qZf9C341vpkT3Q8shDneUHTobnhufn4NLAvTO+qhfBL6fv3Hq936nyW5lVrne4bmnHAk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7bee87b2f5eso73166439f.3 for ; Sun, 21 Jan 2024 14:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705877579; x=1706482379; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3jQUfiUMhuieR4tgeAbkyGE7bS37ygWF/fe7G3ot8B4=; b=ltbYzKECU6qiRLZG5ak/TZxTJ+5GNinSszlNviAG3W2/qH0no3jyLcwYL45o9jvrte +KJaSWH+ZmtyM14KhrwU+rIu8Nj3ZEzbITjHE1+4EFQs9VQ6yknoAeFoncdod6qwMT7a URJdBhuKtv0JIPqMPAWaL+iirdwzVar2aCxgjuyDNBfBjq0vdOLd/qOYxaU6MIvfKCb0 VHAHIDRT1Rhr7/rajO8a9pJ0n89F2+mM/yz6CkuWx6rXW2TQ0hac9TvP1XikkT+rUM6G d38biTepYKpyomJ5ZVyl8gBiCMQCBDgtyfSBnaDqoZHMVwMPU8eGHQC/V6Vrp55+P1+E LOhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705877579; x=1706482379; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3jQUfiUMhuieR4tgeAbkyGE7bS37ygWF/fe7G3ot8B4=; b=S4RLzpc19CA4AKzcJM4dm+ZeIEr95zoFgORETAXYv2GkanQqjjq0D6e6RAna29SpMy vj28UWQlrKVpat7Pv2mee9WnpJ7yYcAwMpmG1zTXoF1Vl7e1EtHNwWS5cU/suyVriKyJ yfpakrVIq/GIFizGkjZtTSCSvP0lQrMbN7Fjd13Lp8A1fSAkDLWzGdaAgXVClqarS5M9 8Hw2I9+vQwW1kkRPYwSeFTu33hpIzY4WSuN/VHg4Y0Hquo+y/RUsr8JGHTtZIFwlee5X t4yU1doEKWYhsz/LhDoJ4Lu+jC9le/z+54yuIuCViH+HyWyolxv/mQkM+8dhDWneI7+/ 98DQ== X-Gm-Message-State: AOJu0YzmYzOmb9k+XNUUYzBu/sKk19B25i/iKxx87vu6N10qKlMBm6cp wWnS2HdXusI1NKAoCp1hQFsMzgi9YnWZkp9mwrQkpYIQhQvg6/eD X-Google-Smtp-Source: AGHT+IF0x76qAvoQ8ADjIZpty91quElnzw8kcM7sCA3uuKqWuOy4oiP1L6NQ8ss1GJrW3iy7cERVlg== X-Received: by 2002:a5d:8750:0:b0:7bb:40db:9a47 with SMTP id k16-20020a5d8750000000b007bb40db9a47mr3347061iol.34.1705877579226; Sun, 21 Jan 2024 14:52:59 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id gc15-20020a056638670f00b0046e3432a5b0sm2793127jab.177.2024.01.21.14.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jan 2024 14:52:58 -0800 (PST) Message-ID: Date: Sun, 21 Jan 2024 15:52:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sra: Disqualify bases of operands of asm gotos Content-Language: en-US To: Martin Jambor , GCC Patches Cc: Richard Biener References: <65a81ace.c80a0220.7bb5d.2f36SMTPIN_ADDED_BROKEN@mx.google.com> From: Jeff Law In-Reply-To: <65a81ace.c80a0220.7bb5d.2f36SMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/17/24 11:21, Martin Jambor wrote: > Hi, > > PR 110422 shows that SRA can ICE assuming there is a single edge > outgoing from a block terminated with an asm goto. We need that for > BB-terminating statements so that any adjustments they make to the > aggregates can be copied over to their replacements. Because we can't > have that after ASM gotos, we need to punt. > > Bootstrapped and tested on x86_64-linux, OK for master? It will need > some tweaking for release branches, is it in principle OK for them too > (after testing)? > > Thanks, > > Martin > > > gcc/ChangeLog: > > 2024-01-17 Martin Jambor > > PR tree-optimization/110422 > * tree-sra.cc (scan_function): Disqualify bases of operands of asm > gotos. > > gcc/testsuite/ChangeLog: > > 2024-01-17 Martin Jambor > > PR tree-optimization/110422 > * gcc.dg/torture/pr110422.c: New test. OK. Also OK for the other release branches with necessary adjustments after testing. jeff