public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] simplify-rtx: The truncation of an IOR can have all bits set (PR81423)
Date: Mon, 24 Jul 2017 22:06:00 -0000	[thread overview]
Message-ID: <d84ebe46-c3e7-db2f-0b5c-56b14fb38509@redhat.com> (raw)
In-Reply-To: <20170724085051.GT13471@gate.crashing.org>

On 07/24/2017 02:50 AM, Segher Boessenkool wrote:
> On Wed, Jul 19, 2017 at 12:19:32AM -0600, Jeff Law wrote:
>> On 07/18/2017 01:36 PM, Segher Boessenkool wrote:
>>> 	* simplify-rtx.c (simplify_truncation): Handle truncating an IOR
>>> 	with a constant that is -1 in the truncated to mode.
>> OK.  A testcase would be advisable :-)
>>
>> jeff
> 
> Like this.  Is this okay for trunk?  (Is int32plus the correct test
> to use here?)
> 
> 
> Segher
> 
> 
> 2017-07-24  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> gcc/testsuite/
> 	PR rtl-optimization/81423
> 	* gcc.c-torture/execute/pr81423.c: New testcase.
I think int32plus just indicates ints are at least 32 bits. But a long
or long long could still be just 32 bits.  so int32plus && long_neq_int,
to ensure that long/long long are 64 bits?

OK with that change.

jeff

  reply	other threads:[~2017-07-24 22:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 19:36 Segher Boessenkool
2017-07-18 19:36 ` [PATCH 2/2] combine: Fix for PR81423 Segher Boessenkool
2017-07-19  6:19 ` [PATCH 1/2] simplify-rtx: The truncation of an IOR can have all bits set (PR81423) Jeff Law
2017-07-19 19:03   ` Segher Boessenkool
2017-07-24  8:56   ` Segher Boessenkool
2017-07-24 22:06     ` Jeff Law [this message]
2017-07-25 11:25       ` Segher Boessenkool
2017-08-07 22:33         ` Segher Boessenkool
2017-08-08 16:27           ` Jeff Law
2017-07-25 11:31     ` Kyrill Tkachov
2017-07-25 22:11       ` Segher Boessenkool
2017-07-26 20:50         ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84ebe46-c3e7-db2f-0b5c-56b14fb38509@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).