From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 915C53857034 for ; Wed, 24 Aug 2022 05:11:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 915C53857034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27O4PBna007336; Wed, 24 Aug 2022 05:11:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=oPy1H+7/4I5PRvcBn7jL+WibhqIIvOy505iw4GfrLno=; b=GJwCDxER+uSvPG+fJtr0TYe7m6WUH+v7NnURrfR+6qL5thA/9C5i3d1B7GHrP2di+g0m uu4QvKkMcf6k5wNs9pJ6sXdzn7jVyrw3jc+BVlEAPKEu/U3jURxQFrBvcB6NEC3p21qf d21bRbcNINdB+70qzPf8gypOZKYJkEF6ShcC3F6hRwzmrkFGnFK9O61Hx7H1JeXa/NVs RE5uAgZ1ooecq71AenfsOjQNIUhTEwbC8qcEXwmBGLSfA0DoeF3jRxLjmRssKMgN9YAR WByWhuel4o6+2rXvJvM6E3mA1N1C9DL3c/D/DU4x7gjuJJe4FhwoPPcbAWZfFDbK4YwK WQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j5cxj14ba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:11:48 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27O4vCXX008971; Wed, 24 Aug 2022 05:11:48 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3j5cxj14an-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:11:48 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27O55B8J028448; Wed, 24 Aug 2022 05:11:46 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06ams.nl.ibm.com with ESMTP id 3j2pvj4nrk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Aug 2022 05:11:46 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27O5Bh1L13238686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Aug 2022 05:11:43 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 21448A405F; Wed, 24 Aug 2022 05:11:43 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75CAFA4054; Wed, 24 Aug 2022 05:11:41 +0000 (GMT) Received: from [9.197.248.248] (unknown [9.197.248.248]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 24 Aug 2022 05:11:41 +0000 (GMT) Message-ID: Date: Wed, 24 Aug 2022 13:11:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions Content-Language: en-US To: Segher Boessenkool Cc: gcc-patches , David , "Kewen.Lin" , Peter Bergner References: <2ffb2ff4-540d-3bcf-4e4e-478acbdd910d@linux.ibm.com> <20220823142620.GU25951@gate.crashing.org> From: HAO CHEN GUI In-Reply-To: <20220823142620.GU25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: V_1uijlTLKmzlu9a7nP47Aj975rGlyfy X-Proofpoint-ORIG-GUID: VbRG5i_ivQPqbwT1Y9nvLBx96WLGlCgq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-24_02,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 malwarescore=0 mlxlogscore=891 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208240021 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, On 23/8/2022 下午 10:26, Segher Boessenkool wrote: > Hi! > > On Fri, Aug 19, 2022 at 10:35:54AM +0800, HAO CHEN GUI wrote: >> --- a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> +++ b/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-exp-0.c >> @@ -1,7 +1,8 @@ >> /* { dg-do compile { target { powerpc*-*-* } } } */ >> -/* { dg-require-effective-target lp64 } */ >> -/* { dg-require-effective-target powerpc_p9vector_ok } */ >> /* { dg-options "-mdejagnu-cpu=power9" } */ >> +/* { dg-additional-options "-mpowerpc64" { target { powerpc*-*-linux* && ilp32 } } } */ > > You can add this always. It is default on 64-bit systems, but it is > simpler to just always add it: > /* { dg-additional-options "-mpowerpc64" } */ > > Or are there subtargets that will error on this? Yes, AIX fails if TARGET_POWERPC64 is set and TARGET_64BIT is not set. So I add "-mpowerpc64" for Linux 32-bit environment. if (TARGET_POWERPC64 && ! TARGET_64BIT) \ { \ error ("%<-maix64%> required: 64-bit computation with 32-bit addressing not yet supported"); \ } Thanks a lot Gui Haochen