From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85624 invoked by alias); 6 Mar 2020 05:44:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 85611 invoked by uid 89); 6 Mar 2020 05:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=H*f:sk:f327382, H*f:sk:820841F, H*i:sk:820841F, H*MI:sk:820841F X-HELO: out30-42.freemail.mail.aliyun.com Received: from out30-42.freemail.mail.aliyun.com (HELO out30-42.freemail.mail.aliyun.com) (115.124.30.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Mar 2020 05:44:11 +0000 X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=junma@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0TrnHejT_1583473444; Received: from 30.25.175.218(mailfrom:JunMa@linux.alibaba.com fp:SMTPD_---0TrnHejT_1583473444) by smtp.aliyun-inc.com(127.0.0.1); Fri, 06 Mar 2020 13:44:05 +0800 Subject: Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps To: Iain Sandoe Cc: gcc-patches , Nathan Sidwell References: <8108a8fc-3ea4-6a3d-d018-5d8d3755cf5b@linux.alibaba.com> <820841F1-826B-48EA-8AC2-2F7EC46987D9@sandoe.co.uk> From: JunMa Message-ID: Date: Fri, 06 Mar 2020 05:44:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <820841F1-826B-48EA-8AC2-2F7EC46987D9@sandoe.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00337.txt 在 2020/3/5 下午9:51, Iain Sandoe 写道: > Hello JunMa, > > JunMa wrote: > >> Ping > > Thanks for your patch(es) and I am sorry this has taken some time to > review. > > (right now, we’re trying to ensure that we have the latest standard > represented in >  GCC10, so updating to n4849). >> >> 在 2020/2/27 上午10:17, JunMa 写道: >>> 在 2020/2/11 上午10:50, JunMa 写道: >>> Hi >>> kindly ping~ >>> >>> Regards >>> JunMa >>>> Hi >>>> As title. in maybe_promote_captured_temps, we promote captured >>>> temporaries >>>> and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains >>>> co_await_expr and maybe other function calls, the side effects flag >>>> should >>>> be set. >>>> >>>> This patch fix one mismatch in cppcoro, the testcase comes from >>>> cppcoro >>>> and is reduced by creduce. > > With the following test conditions; > > r10-7040-ga2ec7c4aafbcd517 >  + the two approved patches by Bin Cheng applied. > >  1/ the test case in this patch (lambda-10-co-await-lambda.C) fails > both with and without the patch. >  2/ the patch regresses one of my local testcases. > The test case fails because of ICE which is fixed by the [PING PATCH coroutines] Do not strip cleanup_point when promote temporaries out of current stmt This patch fix the runtime mismatch. The extra regression is co-await-syntax-11.C which comes from Bin's patch and also is fixed by that patch. Regards JunMa > So, it appears that the testcase might show a bug - but the fix is not > the right one for current trunk? > > Please could you re-check ? > > thanks > Iain