From: Roman Zhuykov <zhroma@ispras.ru>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
Andrea Corallo <andrea.corallo@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops
Date: Fri, 21 Feb 2020 15:49:00 -0000 [thread overview]
Message-ID: <d942fcf0-d81d-70b4-fc4f-98e407fc0f5a@ispras.ru> (raw)
In-Reply-To: <d461cd9e-9ae5-5d71-ad07-7bbe4a2cd119@foss.arm.com>
11.02.2020 14:00, Richard Earnshaw (lists) wrote:
> +(define_insn "*doloop_end"
> +Â [(parallel [(set (pc)
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (if_then_else
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (ne (reg:SI LR_REGNUM) (const_int 1))
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (label_ref (match_operand 0 "" ""))
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (pc)))
> +Â Â Â Â Â Â Â Â Â Â Â Â Â (set (reg:SI LR_REGNUM)
> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (plus:SI (reg:SI LR_REGNUM) (const_int -1)))])]
> +Â "TARGET_32BIT && TARGET_HAVE_LOB && !flag_modulo_sched"
> +Â "le\tlr, %l0")
>
> Is it deliberate that this pattern name has a '*' prefix? doloop_end
> is a named expansion pattern according to md.texi.
>
> R.
21.02.2020 18:30, Kyrill Tkachov wrote:
> +;; Originally expanded by 'doloop_end'.
> +(define_insn "doloop_end_internal"
>
> We usually prefer to name these patterns with a '*' in front to
> prevent the gen* machinery from generating gen_* unneeded expanders
> for them if they're not used.
>
It seems you and Richard asking Andrea to do the opposite things.
:) LOL.patch
Roman
PS. I don't have an idea what approach is correct.
next prev parent reply other threads:[~2020-02-21 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 10:15 Andrea Corallo
2020-02-11 11:01 ` Richard Earnshaw (lists)
2020-02-11 13:40 ` Andrea Corallo
2020-02-12 9:23 ` Roman Zhuykov
2020-02-13 17:54 ` Andrea Corallo
2020-02-19 13:01 ` Andrea Corallo
2020-02-21 15:31 ` Kyrill Tkachov
2020-02-21 15:49 ` Roman Zhuykov [this message]
2020-02-21 15:53 ` Kyrill Tkachov
2020-02-21 15:41 ` Roman Zhuykov
2020-02-24 15:48 ` Andrea Corallo
2020-02-25 14:57 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d942fcf0-d81d-70b4-fc4f-98e407fc0f5a@ispras.ru \
--to=zhroma@ispras.ru \
--cc=Richard.Earnshaw@arm.com \
--cc=andrea.corallo@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).