From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id D583B3858D33 for ; Thu, 6 Jul 2023 15:28:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D583B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-66872d4a141so689285b3a.1 for ; Thu, 06 Jul 2023 08:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688657323; x=1691249323; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m5F3cq+4+RNlvt0m/oITWgWLl48AOO5FovJFDl4uWeQ=; b=Ktlaxp7jS4+AS2yaKtmM/oG2YBphqTXlmGR+DCFjsfqeQqzKBm+484akk/fTnJcIn5 1jZFi1+L9aRdeSsO3Epprcu6kLqOMdpMmMmbN+OFOHdn2UChKUVy2XQpFSBvdLqYZ31W bly00d/kpy0oo5w9CLbpQHXn0hbkEjrnMdAvwd++kRo3n3OI4OaODIyU5X9gADHg/xx6 0F9tJMyO2wnO9dAbc6GJZ2NA5ERRgvvIniC8BxAnZzOLUjPBZdCN4kAnx06vzeocK/62 ItWy83XyoPUPTPtaLemc56c3tINNtI7BGyG8qhp/dcumYmE/jKO016NOKVSqBORVX8ZH rPYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688657323; x=1691249323; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m5F3cq+4+RNlvt0m/oITWgWLl48AOO5FovJFDl4uWeQ=; b=HJyiXAfiCFgkwVSfiB+H1kiBcR15FK86J0afFmIXUtiJIzLSTlk0+WPvSTzD3FteD/ 0RqVjapWCCNxyf/YJEB7KDOaDQO6MTYYx6bQVffNge0Ffb8Bkk0YXeItjyr0xn+aBmap PprkTqJUktp6oK0V8izO2GJg70O6m7438l6nEkETdXIzWU93zDOaRbiMLhCWIdy3XvU8 sg//0BJvOVqUnDg2dfOyY3uFZoA6T3rwSoGjpL+z3me157+UkQgRbJUYAqF2ZLNSs69G KUEDYksdbBiv57KCjJJAfzCa8gw6bGciYy44QSjpwkbnMfibPDkftFc9Ci3e2zR+mfRr riyQ== X-Gm-Message-State: ABy/qLYLnhjvzvZBLBhykTTcJT6THPYE9aKfDltvhKgTLbNCr3+feeOF nm4AeUg/lq+iHrh6QdtzM88= X-Google-Smtp-Source: APBJJlGgGrH6r7TT1qao7q6cdmUwUUuyGdHYdyr90vJHFC4IPdYQXRjjXAnPvuBZZz51puRZjgR1IA== X-Received: by 2002:a05:6a00:14c9:b0:67b:d2e4:6bd2 with SMTP id w9-20020a056a0014c900b0067bd2e46bd2mr1884854pfu.17.1688657322560; Thu, 06 Jul 2023 08:28:42 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id z21-20020aa791d5000000b0063b898b3502sm1420510pfa.153.2023.07.06.08.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 08:28:42 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 09:28:40 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 10/11] riscv: thead: Add support for the XTheadMemIdx ISA extension To: =?UTF-8?Q?Christoph_M=c3=bcllner?= Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Cooper Qu , Lifang Xia , Yunhai Shang , Zhiwei Liu References: <20230428062314.2995571-1-christoph.muellner@vrull.eu> <0e13e932-64c4-fe33-e0f8-21380809a6ba@gmail.com> Content-Language: en-US From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/6/23 00:48, Christoph Müllner wrote: > > Thanks for this! > Of course I was "lucky" and ran into the issue that the patterns did not match, > because of unexpected MULT insns where ASHIFTs were expected. > But after reading enough of combiner.cc I understood that this is on purpose > (for addresses) and I have to adjust my INSNs accordingly. Yea, it's a wart that the same operation has two different canonical forms depending on the context where it shows up :( It's definitely a wart. > > I've changed the patches for XTheadMemIdx and XTheadFMemIdx and will > send out a new series. Sounds good. Jeff