From: Pat Haugen <pthaugen@linux.ibm.com>
To: will schmidt <will_schmidt@vnet.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Peter Bergner <bergner@linux.ibm.com>,
Bill Schmidt <wschmidt@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH, rs6000 V2] Update "prefix" attribute for Power10 [PR99133]
Date: Thu, 18 Mar 2021 15:01:09 -0500 [thread overview]
Message-ID: <d9637c26-e2aa-89ca-19c9-ddfdc2ea8203@linux.ibm.com> (raw)
In-Reply-To: <c3a7d05554d7efcf988b6807dedaca23c8c46650.camel@vnet.ibm.com>
On 3/18/21 11:33 AM, will schmidt wrote:
> Per this change:
>
> +;; Whether an insn is a prefixed insn. A prefixed instruction has a prefix
> +;; instruction word that conveys additional information such as a larger
> +;; immediate, additional operands, etc., in addition to the normal instruction
> +;; word. The default "length" attribute will also be adjusted by default to
> +;; be 12 bytes.
> +(define_attr "prefixed" "no,yes"
> + (if_then_else (eq_attr "prepend_prefixed_insn" "yes")
> + (const_string "yes")
> + (const_string "no")))
>
>
> .. it looks like at least most of the users of the "prefixed" attribute have
> been switched over to use "prepend_prefixed_insn" instead. Are there still
> users of the "prefixed" attribute remaining ? I'm guessing so, given context,
> but can't tell for certain.
>
> (Just a question, not a specific request for a change)
Yes, there are still a couple uses of get_attr_prefixed() in rs6000.c, plus the Power10 scheduling description makes use of it.
-Pat
next prev parent reply other threads:[~2021-03-18 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:49 Pat Haugen
2021-03-18 16:33 ` will schmidt
2021-03-18 20:01 ` Pat Haugen [this message]
2021-03-23 16:50 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9637c26-e2aa-89ca-19c9-ddfdc2ea8203@linux.ibm.com \
--to=pthaugen@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).