From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106318 invoked by alias); 30 Oct 2017 14:16:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106303 invoked by uid 89); 30 Oct 2017 14:16:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f171.google.com Received: from mail-yw0-f171.google.com (HELO mail-yw0-f171.google.com) (209.85.161.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 14:16:15 +0000 Received: by mail-yw0-f171.google.com with SMTP id t71so11660009ywc.3 for ; Mon, 30 Oct 2017 07:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7Md1GgXIGMyAYMQ8emidYfKL/DSqp1EHFryUkKVPeA4=; b=Und4bxwjp82k59tRXGYJ/xf3YEKhXhObXDcuc0UhvsNwsEAS47DAdelJmYklOvcD/h jbJ2pNwNc16uGQECb6ss18Pnu6KAYBRr7G4HFy+VeV708lrvNSFIeNpVfPZ9iTp204s5 +5k+BkJL4QjItc+FfW6QKh7O2CMcKPi05B0z2vGBfPQfQmhOW64YHroehvgzb1tIDa8j 0trtnwg609ANxES6P54IEdDmugHltRqSzSB6uk7oZCjAFa3aF8SakbLWyDdkDSiV9Wyb yeW/bvNCYjgvrfi3E7mPkVzEa8zK8E8R7d5032Zj6D1q8Gwi9q6439/U+6KxCKle+SLo kXGg== X-Gm-Message-State: AMCzsaV97j8YzrvdOPEYx18I8MYcVQg/UaPxW7ilShnmqpCUEzr1yh0r qcEI5sOa26ZPXnAN6s3lHtJdzw== X-Google-Smtp-Source: ABhQp+R9T9cQ7T/Bo8/2R6x+KGg5vwKKF9YL+bJRvqo45LkYLhqpup8fka8y6U4fjx3NL1wQEvY7Og== X-Received: by 10.37.8.70 with SMTP id 67mr5610897ybi.265.1509372973319; Mon, 30 Oct 2017 07:16:13 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254? ([2620:10d:c091:200::3:68fe]) by smtp.googlemail.com with ESMTPSA id s38sm7245043ywa.92.2017.10.30.07.16.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2017 07:16:12 -0700 (PDT) Subject: Re: [PATCH 5/7] GCOV: std::vector refactoring. To: marxin , gcc-patches@gcc.gnu.org References: From: Nathan Sidwell Message-ID: Date: Mon, 30 Oct 2017 14:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg02201.txt.bz2 On 10/26/2017 04:11 AM, marxin wrote: > gcc/ChangeLog: > > 2017-10-26 Martin Liska > > * gcov.c (struct source_info): Remove typedef. > (source_info::source_info): Add proper ctor. > (accumulate_line_counts): Use struct, not it's typedef. > (output_gcov_file): Likewise. > (output_lines): Likewise. > (main): Do not allocate an array. > (output_intermediate_file): Use size of vector container. > (process_file): Resize the vector. > (generate_results): Do not preallocate, use newly added vector > lines. > (release_structures): Do not release sources. > (find_source): Use vector methods. > (add_line_counts): Do not use typedef. ok -- Nathan Sidwell