From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 9039E3857BB1 for ; Fri, 29 Jul 2022 17:03:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9039E3857BB1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,201,1654588800"; d="scan'208";a="83212761" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 29 Jul 2022 09:03:23 -0800 IronPort-SDR: 7vOjGrtZTcXMNssDBbMVyLMQLL7BC5ZgcH9ZLvcQQbTqKG+RcikR49U2Z5621pRq3LFzRsVMcF 8A95zC9XKV6TerpWH6M/zNeOJr4rdLT1s0dZXTuLgAgI6R4VK6iZqTJ6K2GjdDHITbZBwQ1gFl NCDMnxCeJbRpA1OlFzx5HR1GqsP008rV/NOdagVJ78P8swWBNjUo4VcTJF0lQ+1R1g4XgED90r 8VxT1QZqesPJ862zdMnzoV8oDAZJtQFkFkKOcsAlUaUMSfIVrbCmn/9JFdRDOzEAJjB3xV7FTk yJI= Content-Type: multipart/mixed; boundary="------------FveEhbpT0OmEVzEUU4aq3re9" Message-ID: Date: Fri, 29 Jul 2022 18:03:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] openmp-simd-clone: Match shift type Content-Language: en-GB To: Jakub Jelinek CC: "gcc-patches@gcc.gnu.org" References: <02ee1acd-1951-8cf9-345b-ca230ae432bb@codesourcery.com> From: Andrew Stubbs In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 17:04:01 -0000 --------------FveEhbpT0OmEVzEUU4aq3re9 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 29/07/2022 16:59, Jakub Jelinek wrote: > Doing the fold_convert seems to be a wasted effort to me. > Can't this be done conditional on whether some change is needed at all > and just using gimple_build_assign with NOP_EXPR, so something like: I'm just not familiar enough with this stuff to run fold_convert in my head with confidence. > tree shift_cvt_conv = shift_cnt; > if (!useless_type_conversion_p (TREE_TYPE (mask), > TREE_TYPE (shift_cnt))) > { > shift_cnt_conv = make_ssa_name (TREE_TYPE (mask)); > g = gimple_build_assign (shift_cnt_conv, NOP_EXPR, shift_cnt); > gsi_insert_after (&gsi, g, GSI_CONTINUE_LINKING); > } > Your version gives the same output mine does, at least on amdgcn anyway. Am I OK to commit this version? Andrew --------------FveEhbpT0OmEVzEUU4aq3re9 Content-Type: text/plain; charset="UTF-8"; name="220729-simd-clone-shift-types-2.patch" Content-Disposition: attachment; filename="220729-simd-clone-shift-types-2.patch" Content-Transfer-Encoding: base64 b3Blbm1wLXNpbWQtY2xvbmU6IE1hdGNoIHNoaWZ0IHR5cGVzCgpFbnN1cmUgdGhhdCBib3Ro IHBhcmFtZXRlcnMgdG8gdmVjdG9yIHNoaWZ0cyB1c2UgdGhlIHNhbWUgbW9kZS4gIFRoaXMg aXMgbW9zdAppbXBvcnRhbnQgZm9yIGFtZGdjbiB3aGVyZSB0aGUgbWFza3MgYXJlIERJbW9k ZS4KCmdjYy9DaGFuZ2VMb2c6CgoJKiBvbXAtc2ltZC1jbG9uZS5jYyAoc2ltZF9jbG9uZV9h ZGp1c3QpOiBDb252ZXJ0IHNoaWZ0X2NudCB0byBtYXRjaAoJdGhlIG1hc2sgdHlwZS4KCkNv LWF1dGhvcmVkLWJ5OiBKYWt1YiBKZWxpbmVrICA8amFrdWJAcmVkaGF0LmNvbT4KCmRpZmYg LS1naXQgYS9nY2Mvb21wLXNpbWQtY2xvbmUuY2MgYi9nY2Mvb21wLXNpbWQtY2xvbmUuY2MK aW5kZXggMzI2NDliYzNmOWEuLjU4YmQ2OGIxMjliIDEwMDY0NAotLS0gYS9nY2Mvb21wLXNp bWQtY2xvbmUuY2MKKysrIGIvZ2NjL29tcC1zaW1kLWNsb25lLmNjCkBAIC0xMzA1LDggKzEz MDUsMTYgQEAgc2ltZF9jbG9uZV9hZGp1c3QgKHN0cnVjdCBjZ3JhcGhfbm9kZSAqbm9kZSkK IAkJCQkgICAgICAgYnVpbGRfaW50X2NzdCAoVFJFRV9UWVBFIChpdGVyMSksIGMpKTsKIAkg ICAgICBnc2lfaW5zZXJ0X2FmdGVyICgmZ3NpLCBnLCBHU0lfQ09OVElOVUVfTElOS0lORyk7 CiAJICAgIH0KKwkgIHRyZWUgc2hpZnRfY250X2NvbnYgPSBzaGlmdF9jbnQ7CisJICBpZiAo IXVzZWxlc3NfdHlwZV9jb252ZXJzaW9uX3AgKFRSRUVfVFlQRSAobWFzayksCisJCQkJCSAg VFJFRV9UWVBFIChzaGlmdF9jbnQpKSkKKwkgICAgeworCSAgICAgIHNoaWZ0X2NudF9jb252 ID0gbWFrZV9zc2FfbmFtZSAoVFJFRV9UWVBFIChtYXNrKSk7CisJICAgICAgZyA9IGdpbXBs ZV9idWlsZF9hc3NpZ24gKHNoaWZ0X2NudF9jb252LCBOT1BfRVhQUiwgc2hpZnRfY250KTsK KwkgICAgICBnc2lfaW5zZXJ0X2FmdGVyICgmZ3NpLCBnLCBHU0lfQ09OVElOVUVfTElOS0lO Ryk7CisJICAgIH0KIAkgIGcgPSBnaW1wbGVfYnVpbGRfYXNzaWduIChtYWtlX3NzYV9uYW1l IChUUkVFX1RZUEUgKG1hc2spKSwKLQkJCQkgICBSU0hJRlRfRVhQUiwgbWFzaywgc2hpZnRf Y250KTsKKwkJCQkgICBSU0hJRlRfRVhQUiwgbWFzaywgc2hpZnRfY250X2NvbnYpOwogCSAg Z3NpX2luc2VydF9hZnRlciAoJmdzaSwgZywgR1NJX0NPTlRJTlVFX0xJTktJTkcpOwogCSAg bWFzayA9IGdpbXBsZV9hc3NpZ25fbGhzIChnKTsKIAkgIGcgPSBnaW1wbGVfYnVpbGRfYXNz aWduIChtYWtlX3NzYV9uYW1lIChUUkVFX1RZUEUgKG1hc2spKSwK --------------FveEhbpT0OmEVzEUU4aq3re9--