From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15895 invoked by alias); 31 Mar 2017 15:14:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15876 invoked by uid 89); 31 Mar 2017 15:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1276 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Mar 2017 15:14:55 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63141C04D2A3 for ; Fri, 31 Mar 2017 15:14:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63141C04D2A3 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63141C04D2A3 Received: from localhost.localdomain (ovpn-116-213.phx2.redhat.com [10.3.116.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB27884701; Fri, 31 Mar 2017 15:14:54 +0000 (UTC) Subject: Re: Patch ping To: Jakub Jelinek , Jason Merrill References: <20170331063658.GA17462@tucnak> Cc: gcc-patches@gcc.gnu.org From: Jeff Law Message-ID: Date: Fri, 31 Mar 2017 15:15:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170331063658.GA17462@tucnak> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01573.txt.bz2 On 03/31/2017 12:36 AM, Jakub Jelinek wrote: > Hi! > > I'd like to ping two patches: > > PR c++/79572 > - ubsan instrumentation of reference binding to NULL if the reference > is folded into INTEGER_CST with REFERENCE_TYPE > http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01255.html > > PR debug/79255 > - dwarf2out profiledbootstrap ICE while building gnat; > either the posted patch > http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01257.html > or in gen_decl_die: > case FUNCTION_DECL: > + /* decl is NULL only if when processing a function declaration in > + BLOCK_NONLOCALIZED_VARS. It is a normal declaration, not an > + abstract copy of something, so make sure we don't handle it > + like function inlined into something. */ > + if (decl == NULL_TREE) > + { > + decl = origin; > + origin = NULL_TREE; > + } > or something else (another possibility is to replace all decl > uses in case FUNCTION_DECL with decl_or_origin and > - if (!origin) > - origin = decl_class_context (decl); > + if (!decl || !origin) > + origin = decl_class_context (decl_or_origin); I think I prefer your original approach -- pass in the original FUNCTION_DECL. It seems to me like the other approaches are just papering over the issue. Original approach is OK for the trunk. jeff