From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 053E43858D35 for ; Sun, 30 Apr 2023 18:30:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 053E43858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-5286311be47so1143766a12.1 for ; Sun, 30 Apr 2023 11:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682879442; x=1685471442; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TZibnvHb2d65Efr/1SOphapzAuAww4lHjBbs+Zvx810=; b=DI0XLjVGwg553xvdwhTUMvZxViCKXD8RElqDXKiTbz2EAru58XlhGK7VdRG7TTWdkv A/I969PAYmZa81ZPDLKQ/Ii7mPbzcecMADIEuPe6mYMIH01tlLWIsq+b/tbfvbNDkP6f 1eJSuOR10TzZ2KQpVIDArpjjkJwbx3xtxt5fCF9za2aY/31i94TQQDC/5RP08nHbrjIL UJnmArvMKhFC3jsaS7IeJdflc20Ac/9OrX2zkSf38dnBD0Fm4YYmo57MaJXMR6jWA3uL mBHGnvrw9XRyTwploF1seNfCS+BqGN+jT9BQXW4zwGUrrVqJnq1cJcZSqlPkAABledNw hM8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682879442; x=1685471442; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TZibnvHb2d65Efr/1SOphapzAuAww4lHjBbs+Zvx810=; b=lPwhb8X9CFeiwkvmL7IQdna7leRXR2unCOdVjEQpckFeP0SFXp5k/xfO+CyJCPDdOr J8ylC5ZiXoCAg5dmGf1txAMqh36G7tTTZVYhDw6C9LEXTQ+ziRuZAah8UK8ukRzOEfhg BugwK3BvBOn5x2TicjKDs6qsN8oPBID24uQBPsKpN4qpc4QZO8Fe50IE1fK9OBjLqLrZ mefvjpCm/SqV8lxucznK/mCw+fsD3RjZSugpEranITxdEM7BP7cLnPtxcho0uGGCj99j PSLWY9W7Nq5v3QSQpr4nJCfihLPOjZEPmL8H8VBN+rQCAJu7dvmkgdiTiAfazifXVQq1 j/ug== X-Gm-Message-State: AC+VfDygF3Uu+qWjeLBTegmZ5L6hWan1DFRVUpebrPDz5YD760TAUYaE bSsFTjTOiS5UOp8M2Qt3oI4= X-Google-Smtp-Source: ACHHUZ7/8Y6CAahnlSZGo4V28R+NOx2juV9uBXrQzIVYdrDCqD9kKZUiR3nnO7CNfbfhmiEd5rI8lA== X-Received: by 2002:a17:902:c411:b0:1a0:4ebd:15d5 with SMTP id k17-20020a170902c41100b001a04ebd15d5mr13726751plk.67.1682879441812; Sun, 30 Apr 2023 11:30:41 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id a9-20020a170902900900b001a514d75d16sm16461636plp.13.2023.04.30.11.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Apr 2023 11:30:41 -0700 (PDT) Message-ID: Date: Sun, 30 Apr 2023 12:30:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] libcpp: suppress builtin macro redefined warnings for __LINE__ Content-Language: en-US To: Longjun Luo , Joseph Myers Cc: gcc-patches@gcc.gnu.org, sangyan@huawei.com References: <20221201043155.9369-1-luolongjuna@gmail.com> <8767c6bc-5b37-ca10-1176-e341081c555f@gmail.com> <587de9c9-e46f-b69e-84d8-7356a19db74@codesourcery.com> <6ac6c8e6-d18a-8aae-2ae3-ecdfed291755@codesourcery.com> <86625ca4-6ef5-4010-e452-aa2e1149215f@gmail.com> From: Jeff Law In-Reply-To: <86625ca4-6ef5-4010-e452-aa2e1149215f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/12/23 09:02, Longjun Luo via Gcc-patches wrote: > From 0821df518b264e754d698d399f98be1a62945e32 Mon Sep 17 00:00:00 2001 > From: Longjun Luo > Date: Thu, 12 Jan 2023 23:59:54 +0800 > Subject: [PATCH] libcpp: suppress builtin macro redefined warnings for >  __LINE__ > > As implied in > gcc.gnu.org/legacy-ml/gcc-patches/2008-09/msg00076.html, > gcc provides -Wno-builtin-macro-redefined to suppress warning when > redefining builtin macro. However, at that time, there was no > scenario for __LINE__ macro. > > But, when we try to build a live-patch, we compare sections by using > -ffunction-sections. Some same functions are considered changed because > of __LINE__ macro. > > At present, to detect such a changed caused by __LINE__ macro, we > have to analyse code and maintain a function list. For example, > in kpatch, check this commit > github.com/dynup/kpatch/commit/0e1b95edeafa36edb7bcf11da6d1c00f76d7e03d. > > So, in this scenario, when we try to compared sections, it would > be better to support suppress builtin macro redefined warnings for > __LINE__ macro. > > Signed-off-by: Longjun Luo > --- >  gcc/testsuite/gcc.dg/builtin-redefine-1.c | 49 +++++++++++++++++++++++ >  gcc/testsuite/gcc.dg/builtin-redefine.c   | 24 +++++++++-- >  libcpp/init.cc                            |  2 +- >  3 files changed, 70 insertions(+), 5 deletions(-) >  create mode 100755 gcc/testsuite/gcc.dg/builtin-redefine-1.c Thanks. I added a suitable ChangeLog and pushed this to the trunk. jeff