From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 55C623858D28 for ; Fri, 11 Aug 2023 14:15:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55C623858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-687087d8ddaso1932484b3a.1 for ; Fri, 11 Aug 2023 07:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691763347; x=1692368147; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nYUl8oKyxT+C7wXXsPNPj10+J9K1WK3nPp3JWwEfZaI=; b=Ko8Q8COzBGVj4rQJOtepVPkFamPcyaCYpviaBNuHif4hny06tJjb4c4pBlMtH9qTIW c7M2t/bs1ZbinViKLP0QLV0h+X0SFysFmW0BTKkNWxKIqY//j+BJAwnWRUYksbbMh6aG eA/ojanj5q0Jo754Qt/Vc4zRoJXQUy8OUY2/G6FCYCV7LvDOKfeWB+sBw/2zNvg8XoEp lWXQEihpApPPg9foD1Xv4eMmwNfWpMtB3G8TA72AECnBl11qWP419KCvNHAPzsutVwhk /CUn8NHI7O3qo5M0P7MCpDhdVUeJVlBONd3krFnFVrv5Z2sYicLYnMdJ93rRzEnukXvr WXIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691763347; x=1692368147; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nYUl8oKyxT+C7wXXsPNPj10+J9K1WK3nPp3JWwEfZaI=; b=cgyjmddDw6Yq2VM6lYzNriddfEqM7QiYnvYs3Gvie0vbtirT5FfthHIprN+Y7swB1r nDbIXgS1AzLe/UWtOFrTSKqjhMPppCK001km6Huke2Lb3Zfeo7LTqY+vvYnSRolG2yo1 CPBoWlIV1RLm/ljkSEgYqlPBmWup6zUjaaDKkYi3ab5FJP7+QjLUdRqjVxd1mKIpYbz7 EF/NnASF8qyANqHhVtBuOLn1+aEiExyAwWj8kceWxnVq8Sz4X9AsxvJlKrWFbZzmQkO0 jpVGorq5FF4AieKHGSQg+xrwjfu+y001JH2R8fNoetdazXGrhPWX50PMGIFfezGa4BHw oa3Q== X-Gm-Message-State: AOJu0YyvxPdzjMClQwziWcdJZvn2G5l5lvWxcz1/Hq4uu7Z1YZ0HH8RP r1oj8kX3+qvq7nuPpl/fY2s= X-Google-Smtp-Source: AGHT+IFoaiMUDJ2U16mht/qqR/MVqMI8fWif6xLJYxeCCC3TM/j14M6ZPoAhDliM/HfLPBwRUv08AQ== X-Received: by 2002:a05:6a21:7189:b0:137:53d1:405 with SMTP id wq9-20020a056a21718900b0013753d10405mr2232929pzb.26.1691763347007; Fri, 11 Aug 2023 07:15:47 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id b12-20020aa7810c000000b006862b2a6b0dsm3485602pfi.15.2023.08.11.07.15.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 07:15:46 -0700 (PDT) Message-ID: Date: Fri, 11 Aug 2023 08:15:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] RISC-V: Revive test case PR 102957 Content-Language: en-US To: Tsukasa OI , Kito Cheng , Palmer Dabbelt , Andrew Waterman , Jim Wilson Cc: gcc-patches@gcc.gnu.org References: <3aa13843de038d960fdb3415f416243e43b376f2.1691745095.git.research_trasio@irq.a4lg.com> From: Jeff Law In-Reply-To: <3aa13843de038d960fdb3415f416243e43b376f2.1691745095.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/11/23 03:11, Tsukasa OI via Gcc-patches wrote: > From: Tsukasa OI > > Commit c283c4774d1c ("RISC-V: Throw compilation error for unknown > extensions") changed how do we handle unknown extensions and > commit 6f709f79c915a ("[committed] [RISC-V] Fix expected diagnostic messages > in testsuite") "fixed" test failures caused by that change (on pr102957.c, > by testing the error message after the first change). > > However, the latter change will break the original intent of PR 102957 test > case because we wanted to make sure that we can parse a valid two-letter > extension name. > > Fortunately, there is a valid two-letter extension name, 'Zk' (standard > scalar cryptography extension superset with NIST algorithm suite). > > This commit puts this extension name and revives the intent of the test case > for PR 102957. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/pr102957.c: Remove "dg-error" because we don't > need to test for error message. Use the 'Zk' extension to continue > testing whether we can use valid two-letter extensions. This doesn't look right to me. The whole point of this specific dg line is to verify that we get an error with an invalid extension specification. What might make more sense would be to split this into two tests. One which continues to test that we get an error for something like zb and the other with everything else. jeff