From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id 31D053858D33 for ; Sun, 22 Jan 2023 19:04:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31D053858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1029.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so12625983pjq.0 for ; Sun, 22 Jan 2023 11:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uSnAIn2Rh3tRuCqBLiQZsrEq8PJPKspVSlaGil/oz2Q=; b=jkN7XkMI6VfdhEFBj+wg0rmM6MnLrxXhwHvqEBHcVxe3zhGPGdibctLCUDUAQMj3le 0V8jE//T42U2mUWnxVrJzKKUQwYf1mvJFrs3zH6GSxOIK7i/GtuWcjunaCl+jkY+blTi t8F5sU/PFPHTbQTqhoizySXaS1wr9Dzjyy6MpJFmxfsPiUGuDRh8387BQlDR1GfxvmEW J51/GZFib9xdHPvqQYCRGcbW1PGrAcUop3D44exlsobUt6D/ky1jwW0KGfGLOkulcibv npmXFi2xSKYIDGksyc34fVoS/4r5aeQmyPxqe3tI3034cEGTv+3UCmYgNA5AiSEAzLmE GWiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uSnAIn2Rh3tRuCqBLiQZsrEq8PJPKspVSlaGil/oz2Q=; b=qbrBrD2ZZHYUVwYrzQFUnTTEZE7RNHydVl6rWBBqrTMpVjK3WUQ2mF1aBq44cZ5r0Z 7d3jU/efiZvYmaonedIMEmjag9wRaJmnMr7LMIIMpqVG05ZTAf2CHST7p9g65r82A7Uu Zt6KuROI3GVC/hXROQhwxwKGYfY82U6gkVnKQse0CvCdiKLyDxNIStLzI1iofnihTYF3 Vr55EIipcEdVnyGASmkYGzwZvqFCBNhIU2bQyHJ6f/S3MU4Un6D48HHqto8It5SMPdGW 9CgP3F6tf/ZDZ+0Nv6COKnSgiwuebZ851xIs/+JhqTQF0D8Z3UZ0pYLdM7fwmGcAqq/8 lNww== X-Gm-Message-State: AFqh2kq26tjF970zlPvHfysClXthk8iQdOE+/P+lw//a5r/5iw3Rzeb3 VcFdMvgyW+nsco9Fjkuzgis= X-Google-Smtp-Source: AMrXdXuFsnE9AODqZKkByPmI3h1gzabNpHOoae6A5ehCvkQWYbn35DKjyRBZxXYPTe2oYPjXWNahmA== X-Received: by 2002:a17:90a:690c:b0:227:1745:3478 with SMTP id r12-20020a17090a690c00b0022717453478mr22414735pjj.30.1674414283939; Sun, 22 Jan 2023 11:04:43 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id t21-20020a635355000000b0049f5da82b12sm25050723pgl.93.2023.01.22.11.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 11:04:43 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:04:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/2] Corrected pr25521.c target matching. Content-Language: en-US To: Cupertino Miranda Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> From: Jeff Law In-Reply-To: <875yen5ib4.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/7/22 08:45, Cupertino Miranda wrote: > >> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>> This commit is a follow up of bugzilla #107181. >>> The commit /a0aafbc/ changed the default implementation of the >>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>> placement of `const volatile' objects. >>> However, the following targets use target-specific selection functions >>> and they choke on the testcase pr25521.c: >>> *rx - target sets its const variables as '.section C,"a",@progbits'. >> That's presumably a constant section. We should instead twiddle the test to >> recognize that section. > > Although @progbits is indeed a constant section, I believe it is > more interesting to detect if the `rx' starts selecting more > standard sections instead of the current @progbits. > That was the reason why I opted to XFAIL instead of PASSing it. > Can I keep it as such ? I'm not aware of any ongoing development for that port, so I would not let concerns about the rx port changing behavior dominate how we approach this problem. The rx port is using a different name for the section. That's valid thing to do and to the extent we can, we should support that in the test rather than (incorrectly IMHO) xfailing the test just becuase the name isn't what we expected. To avoid over-eagerly matching, I would probably search for "C," I wouldn't do that for the const or rodata sections as they often have a suffix like 1, 2, 4, 8 for different sized rodata sections. PPC32 is explicitly doing something different and placing those objects into an RW section. So for PPC32 it makes more sense to skip the test rather than xfail it. Jeff