From: Xi Ruoyao <xry111@xry111.site>
To: Lulu Cheng <chenglulu@loongson.cn>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH v1] LoongArch: Define the macro ASM_PREFERRED_EH_DATA_FORMAT by checking the assembler's support for eh_frame encoding.
Date: Fri, 29 Jul 2022 11:18:19 +0800 [thread overview]
Message-ID: <dc30f0d9cb08e3ec3905c53ab3189f2bcf6f63e5.camel@xry111.site> (raw)
In-Reply-To: <20220729024337.4182683-1-chenglulu@loongson.cn>
On Fri, 2022-07-29 at 10:43 +0800, Lulu Cheng wrote:
> .eh_frame DW_EH_PE_pcrel encoding format is not supported by gas <= 2.39.
> Check if the assembler support DW_EH_PE_PCREL encoding and define .eh_frame
> encoding type.
>
> gcc/ChangeLog:
>
> * config.in: Regenerate.
> * config/loongarch/loongarch.h (ASM_PREFERRED_EH_DATA_FORMAT):
> Select the value of the macro definition according to whether
> HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT is defined.
> * configure: Regenerate.
> * configure.ac: Reinstate HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT test.
To me it looks a little strange to list regenerated config.in &
configure before configure.ac. But maybe I'm wrong here if a
lexicographical order is preferred...
/* snip */
> + gcc_GAS_CHECK_FEATURE([eh_frame pcrel encoding support],
> + gcc_cv_as_loongarch_eh_frame_pcrel_encoding_support,,
> + [.LFB1780 = .
> + .cfi_startproc
> + .cfi_personality 0x9b,DW.ref.__gxx_personality_v0
> + .cfi_lsda 0x1b,.LLSDA1780
> + .cfi_endproc],,
I think the conftest content can be simplified to:
.cfi_startproc
.cfi_personality 0x9b,a
.cfi_lsda 0x1b,b
.cfi_endproc
> + [AC_DEFINE(HAVE_AS_EH_FRAME_PCREL_ENCODING_SUPPORT, 1,
> + [Define if your assembler supports eh_frame pcrel encoding.])])
> ;;
> s390*-*-*)
> gcc_GAS_CHECK_FEATURE([.gnu_attribute support],
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-07-29 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 2:43 Lulu Cheng
2022-07-29 3:18 ` Xi Ruoyao [this message]
2022-07-29 3:51 ` Lulu Cheng
2022-07-29 3:55 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc30f0d9cb08e3ec3905c53ab3189f2bcf6f63e5.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).