From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48678 invoked by alias); 4 Jul 2018 00:20:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48651 invoked by uid 89); 4 Jul 2018 00:20:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jul 2018 00:20:38 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A75343084037; Wed, 4 Jul 2018 00:20:37 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-54.rdu2.redhat.com [10.10.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93CCA17F8C; Wed, 4 Jul 2018 00:20:36 +0000 (UTC) Subject: Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]] To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org Cc: dvlasenk@redhat.com, Segher Boessenkool References: <9bb1dbf4-b0ef-544c-fb02-b0262a39b87d@redhat.com> <82d6c10f-22d3-f2e8-c6b9-55cd6469966b@suse.cz> From: Jeff Law Openpgp: preference=signencrypt Message-ID: Date: Wed, 04 Jul 2018 00:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <82d6c10f-22d3-f2e8-c6b9-55cd6469966b@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00169.txt.bz2 On 07/03/2018 01:11 PM, Martin Liška wrote: > On 07/03/2018 10:53 AM, Martin Liška wrote: >> Thank you Jeff. >> >> I found some issues when doing build of all targets >> (contrib/config-list.mk). >> I'll update patch and test that affected cross-compilers still produce >> same output. > > Hello. > > I'm done with testing, I bootstrapped and regtested the patch on > x86_64-linux and ppc64-linux-gnu. > I also build all cross compilers we have in contrib/config-list.mk and I > verified that > results for gcc/gcc/testsuite/gcc.dg/params/blocksort-part.c source file > is equal for all cross compilers > that I touched in the patch. I tested these options: > > -O2 > -O2 -falign-loops=256 > -O2 -falign-loops=256 -falign-functions=512 -falign-labels=1024 > -falign-jumps=2048 > -O2 -falign-loops=1024 -falign-functions=512 -falign-jumps=2048 > -O2 -falign-loops=256 -falign-jumps=2048 > -O2 -falign-loops=100 -falign-functions=200 -falign-labels=300 > -falign-jumps=400 > -O2 -falign-loops=1111 -falign-functions=1112 -falign-labels=1113 > -falign-jumps=1114 > > there are no issues except one that are present on current trunk: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86394 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86390 > > Is the patchset still ready for approval? Yes. jeff