From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id E418C385803B for ; Wed, 20 Dec 2023 03:52:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E418C385803B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E418C385803B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703044369; cv=none; b=o7GJmxRZhMH4X3goZW1aJNFREhbLJTO9UppmtUIqh9ucXRWgWPzLcxLP8DiVj+sCvlrQ88LIiJnBY5ozvV8kZH4HwxzVHBl+7TqURgizwxHINGU03OyGHuwcqOwo+/kuu6o3+kWNcvv+JrC/7YMVQOK+IOcQb4u2pA0eDmwVjO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703044369; c=relaxed/simple; bh=JnXpHMGSVhMx9MMZ9cW1kDX5LjzhX8B0Gro8jruU0Yk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=kf/5iXk2LG2p/tKhlGWUe/UfZAeNXp4SEbtoFfxBqmHQi5nJS+Blk6Z9bDg0yAjSuUqc3WSTx9kNbKZBzD0HzdNBK4nNpzcyqDi1cmVzuuZZgHdRVc/wBHqG4CogWGQXw9LXEaqY8Cn3dV14nygS9GPiFf+8Rq+EDKpT3qMvryY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.15]) by gateway (Coremail) with SMTP id _____8BxNPALZYJlJ9UCAA--.14401S3; Wed, 20 Dec 2023 11:52:44 +0800 (CST) Received: from [10.20.4.15] (unknown [10.20.4.15]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxrr4IZYJlWnMBAA--.2119S3; Wed, 20 Dec 2023 11:52:41 +0800 (CST) Message-ID: Date: Wed, 20 Dec 2023 11:52:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] LoongArch: Fix PR113033 and clean up code Content-Language: en-US To: chenglulu , Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn, c@jia.je, Guo Jie References: <20231219065957.70665-1-xry111@xry111.site> <73a4f640-34c5-02c0-d2d1-5e39aef952ed@loongson.cn> From: Chenghui Pan In-Reply-To: <73a4f640-34c5-02c0-d2d1-5e39aef952ed@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8Bxrr4IZYJlWnMBAA--.2119S3 X-CM-SenderInfo: psdquxxhqjx33l6o00pqjv00gofq/1tbiAQALBGWCTy4B9AAAs9 X-Coremail-Antispam: 1Uk129KBj93XoW7GFWDGw4ftFW5Zr4rCryxCrX_yoW8Jr15pF Z3Ca43trWkJrZ7Wwn2y3yUXry5Jr4xG34Uur4ftFy8Ar15Aryjqr18G39a9Fy3Ja9Ygr12 qr4Uuan8uF1jvagCm3ZEXasCq-sJn29KB7ZKAUJUUUUr529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2kKe7AKxVWUXVWUAwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07 AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWU XVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI4 8JMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E14v26r1Y 6r17MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7 AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE 2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcV C2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73 UjIFyTuYvjxU74lkDUUUU X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The patches are look ok and no problem in spec2017 correctness check. On 2023/12/19 15:26, chenglulu wrote: > We will read and test these patches as soon as possible. > > Thanks! > > 在 2023/12/19 下午2:59, Xi Ruoyao 写道: >> Superseds >> https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640871.html. >> >> Per Jakub's response, vec_init patterns do not have a predicate on the >> input operand so the operand can be *anything*.  It's not safe to simply >> move it into an reg, and we have to use force_reg instead. >> >> The code clean up is separated into the 2nd patch to make reviewing >> easier. >> >> Bootstrapped and regtested on loongarch64-linux-gnu.  Ok for trunk? >> >> Xi Ruoyao (2): >>    LoongArch: Use force_reg instead of gen_reg_rtx + emit_move_insn in >>      vec_init expander [PR113033] >>    LoongArch: Clean up vec_init expander >> >>   gcc/config/loongarch/loongarch.cc             | 54 +++++++------------ >>   gcc/testsuite/gcc.target/loongarch/pr113033.c | 23 ++++++++ >>   2 files changed, 43 insertions(+), 34 deletions(-) >>   create mode 100644 gcc/testsuite/gcc.target/loongarch/pr113033.c >>