From: Robin Dapp <rdapp.gcc@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>,
"richard.sandiford" <richard.sandiford@arm.com>
Cc: rdapp.gcc@gmail.com, gcc-patches <gcc-patches@gcc.gnu.org>,
rguenther <rguenther@suse.de>
Subject: Re: [PATCH] internal-fn: Add VCOND_MASK_LEN.
Date: Thu, 26 Oct 2023 22:32:04 +0200 [thread overview]
Message-ID: <dce43ea1-0cd5-4951-966d-3a96d0f864b9@gmail.com> (raw)
In-Reply-To: <EDFFE01677219BB1+20231026221057054091101@rivai.ai>
> +(define_expand "vcond_mask_len_<mode>"
> + [(match_operand:V_VLS 0 "register_operand")
> + (match_operand:<VM> 3 "nonmemory_operand")
> + (match_operand:V_VLS 1 "nonmemory_operand")
> + (match_operand:V_VLS 2 "autovec_else_operand")
> + (match_operand 4 "autovec_length_operand")
> + (match_operand 5 "const_0_operand")]
>
> I think you should change V_VLS into V since we never apply partial vectorization (predicated by length)
> on VLSmodes. VLSmodes are the modes used on GNU vector/SLP/SIMD vectorizations.
Right, thanks. That was likely copy and paste from vcond_mask.
Changed it and re-tested but not going to send another version
before more changes are requested.
Regards
Robin
next prev parent reply other threads:[~2023-10-26 20:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 22:10 钟居哲
2023-10-25 22:32 ` Richard Sandiford
2023-10-25 22:35 ` 钟居哲
2023-10-26 8:41 ` Robin Dapp
2023-10-26 14:02 ` Robin Dapp
2023-10-26 14:10 ` 钟居哲
2023-10-26 20:32 ` Robin Dapp [this message]
2023-11-02 13:35 ` Richard Biener
2023-11-02 13:48 ` Robin Dapp
2023-11-02 23:49 ` Richard Sandiford
2023-11-03 9:03 ` Robin Dapp
2023-11-03 9:11 ` Richard Sandiford
2023-11-03 22:02 ` Robin Dapp
2023-11-05 20:28 ` Richard Sandiford
2023-11-06 7:22 ` Richard Biener
-- strict thread matches above, loose matches on Subject: below --
2023-09-08 9:01 [PATCH] gimple-match: Do not try UNCOND optimization with COND_LEN Robin Dapp
2023-09-11 20:35 ` Robin Dapp
2023-10-12 13:53 ` Richard Sandiford
2023-10-12 14:19 ` Richard Sandiford
2023-10-13 15:50 ` Robin Dapp
2023-10-16 21:59 ` Richard Sandiford
2023-10-17 8:47 ` Richard Biener
2023-10-17 11:39 ` Robin Dapp
2023-10-17 13:35 ` Richard Sandiford
2023-10-17 15:42 ` Robin Dapp
2023-10-17 16:05 ` Richard Sandiford
[not found] ` <7e083b67-f283-4e9e-ba76-24e194fa1761@gmail.com>
[not found] ` <mptttqmny4u.fsf@arm.com>
2023-10-23 16:09 ` [PATCH] internal-fn: Add VCOND_MASK_LEN Robin Dapp
2023-10-24 21:50 ` Richard Sandiford
2023-10-25 19:59 ` Robin Dapp
2023-10-25 21:58 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce43ea1-0cd5-4951-966d-3a96d0f864b9@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).