From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 3234C3858D32 for ; Thu, 26 Oct 2023 20:32:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3234C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3234C3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698352328; cv=none; b=vbkvYaGeCnKuWjagZ9M0/upq0zux1km2g+iG/rznivoih/vMWEeDdgbE8LsdRYz1KANOZFcylwpH47U/ekx2FwLMpBaDnyDaRokGHuzQxRp1j6XAKOLWFFeqcR/PeaM/PuKgsWWJhLCfLTGJcouUna9zq8xygp5MXdwCLzAwcrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698352328; c=relaxed/simple; bh=ZA5WG3p7rojhMarRJ4dF5dbAFm3Y6RfSjI1KCWC6cas=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RcIoY9CVUzqw+Qv1NxaWV5vHsug8JBa+BJFFh/xLq9jbkE1+jmaBIczJzbvnxv7iCJ8YNABX1DMUHqJgHw3SyBHHLBi4o6UmOR6k218c/5uIjq0P624P0QrCd/ut24lkxsubJEA1haEXXGH5KS07MQz7MwiwU4HAHVtKwJiZO+k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4084b0223ccso10455325e9.2 for ; Thu, 26 Oct 2023 13:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698352326; x=1698957126; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vHbLEXCr56uqN5hIjVmBb+zx82HgI/wzfXBUJ4N5QUk=; b=XErBiB8WHRRoEnkh7lYW8E/z+Ir/Wk6QRh7gbQbjxfbKkCM0PQtK8hOVUqQbFDrSZW VFOGYPDABA3eGNTg6sdTsDvXHYYmNW2hoYfpvTI2DaSGjSwxNtCNVY3ndXDMIqHdKD/e /zHQGNCjr28Ae2z1mFiTVoFQysdxRsHOwXDPwBXhe9O38dUCot33q9jPl8E2Dp/6rPza lBuXwdlDNnIUQ0vDA8stUpxhV2BerKonpv3f1JGCnu4AgxjSA+MVxVZr1AkpyEprFZ6T QVKzmb7D1l4Joia8XyQPqyF5w9/GXn0gcPR4FQf0WMrHT2KZdd48kMjnthIGrcegC7Ma zWtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698352326; x=1698957126; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vHbLEXCr56uqN5hIjVmBb+zx82HgI/wzfXBUJ4N5QUk=; b=aMi8DSb37ohXJxguB60fFHJkjypWlKneG2OrP9S4QKIJqFyis3YhkUuCtZbfl9DCux 5j4t5ZVe+OMQjYmVuUxAhtbimbNCaBZkgfNg15RnsfREtIhZdkOQhHfaGzxZ7cNxyzNX zYozcOXOs1h8A9r9fv4Lq+FlmQ4ZJo00HCZxtw/TvhurdGpcdn7E1CX3CoqJeZshQsX9 z0xwhv+3tHcXShafmPy97Eh5brqv+bz+TR0nv7BFsEs+KmEnkdXR64gVdkWapTcQng1y fy+69+qoGhWjDkClBCvLqvVUZGwxi2dkQjc3UWI2Ove7sl0WkHZM9nPfu5gclP2PeCaX qE4Q== X-Gm-Message-State: AOJu0Ywj6+l4gjm/G1whXik8E0ugyMuYq3fI9RGaHXgUUrq25UJYFRfj GZPgoVzD9JtH1xIvyYMqfiwOUxGkAfk= X-Google-Smtp-Source: AGHT+IHEa/Jj4rhUqEi25r4pUX+q9MEj66CGnyrFizbLw10OdzkybeJXwG1Bm7JF5YXQlzNaxOB54Q== X-Received: by 2002:a05:600c:154e:b0:408:4083:fbf2 with SMTP id f14-20020a05600c154e00b004084083fbf2mr687341wmg.22.1698352325770; Thu, 26 Oct 2023 13:32:05 -0700 (PDT) Received: from [192.168.1.24] (ip-046-223-203-173.um13.pools.vodafone-ip.de. [46.223.203.173]) by smtp.gmail.com with ESMTPSA id n41-20020a05600c3ba900b004060f0a0fdbsm3485070wms.41.2023.10.26.13.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Oct 2023 13:32:05 -0700 (PDT) Message-ID: Date: Thu, 26 Oct 2023 22:32:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, gcc-patches , rguenther Subject: Re: [PATCH] internal-fn: Add VCOND_MASK_LEN. Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , "richard.sandiford" References: <818fe7b8-cb55-49d1-94fa-f929b8cbc5d8@gmail.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > +(define_expand "vcond_mask_len_" > +  [(match_operand:V_VLS 0 "register_operand") > +    (match_operand: 3 "nonmemory_operand") > +    (match_operand:V_VLS 1 "nonmemory_operand") > +    (match_operand:V_VLS 2 "autovec_else_operand") > +    (match_operand 4 "autovec_length_operand") > +    (match_operand 5 "const_0_operand")] > > I think you should change V_VLS into V since we never apply partial vectorization (predicated by length) > on VLSmodes.  VLSmodes are the modes used on GNU vector/SLP/SIMD vectorizations. Right, thanks. That was likely copy and paste from vcond_mask. Changed it and re-tested but not going to send another version before more changes are requested. Regards Robin