From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 18EA33858D37 for ; Fri, 25 Aug 2023 23:45:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18EA33858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3a76d882080so1032256b6e.2 for ; Fri, 25 Aug 2023 16:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1693007104; x=1693611904; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9jC3RDQ37fdMbZ85C9gMFaR/u902ZICVp6wFW5Va8HA=; b=DLABE9G4OumNGZfbTqn/Di3Ru/r9urUpQXwpYukbC0w8gAGht40aCEHkcAP/V0RFrJ ip5iQYP9LlvtQmrK6U8S6a+f+EV8lVK+X73osGSMgkBVYmqa3ygJ/N6bosG1k3tPoBcv HeQAM6H0INhbNN4r0CbVlPwLbhVIoWtcS5Phw+lYlWc70XTej6Ddi6zdOpaR7s0U/n/5 GRsrc8VyEoGv3qrWQuuIdnKcqmLBa/JbL/OEKkwW/1f0MbaQ4BzWdLs8sY5QB9/slT02 baD+eNEeQznsAhOU2zeTarYD6UGeLEeyVi4EDp5Y2aPXEtDcGotVU8N3YuybCCa3GHXG ZEfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693007104; x=1693611904; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9jC3RDQ37fdMbZ85C9gMFaR/u902ZICVp6wFW5Va8HA=; b=eszPsnDptFaOy7/vv0aw2/oDhoPYHy24BgAnAv0gujS1p8Le4aSGnFviqQj3SX1mU4 WSyy5cWg0WvuQFyskZg3SgKKSx6zDu8NDB+Smrthg9Y2n4VTBKWr8gD7clk5bFAHafXT u240H2+GBTL9Bh1cuzxspn+o5aQU1hg7kmrktID9atvGqZIYRUmV6jcO1C810QZ7yFdI XCycV/NZoTg85/7tFjcXAhL0i6Yxcx2KANRfwJQAM4SkriwGkZ/zZuRhkdVRPeTlUDQn A7q4jTgXMTh04gpJRp3DBq6m96t4CQCzlzPnoGXLPt2HuOmZaGWqmFHjIHLfoq2E5v0y 6ohQ== X-Gm-Message-State: AOJu0YwXfuXx9GNRk/yBIc4ecVgJUGLp3D2OAjlQtJmNrgjECRq+Osl3 2C1EzoTRxiGLpP0OT8e7nhRSVA== X-Google-Smtp-Source: AGHT+IEu6bZzpYdGud+kIZf3zUgXjJfhzXIgeynAlsLwBWlWNNrzELxuRD8vwyupsbeqIfGeV8HV4Q== X-Received: by 2002:a05:6358:63a8:b0:134:c815:f067 with SMTP id k40-20020a05635863a800b00134c815f067mr23130095rwh.11.1693007104169; Fri, 25 Aug 2023 16:45:04 -0700 (PDT) Received: from [10.0.17.144] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id m185-20020a633fc2000000b005642314f05fsm2163924pga.1.2023.08.25.16.45.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 16:45:03 -0700 (PDT) Message-ID: Date: Fri, 25 Aug 2023 16:44:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] RISC-V: Add Types to Un-Typed Sync Instructions: Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com Newsgroups: gmane.comp.gcc.patches References: <20230824211957.671151-1-ewlu@rivosinc.com> <5a02fd13-95af-768a-f61d-7daf890076fa@gmail.com> From: Edwin Lu In-Reply-To: <5a02fd13-95af-768a-f61d-7daf890076fa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/25/2023 11:53 AM, Jeff Law via Gcc-patches wrote: > > > On 8/24/23 15:19, Edwin Lu wrote: >> Related Discussion: >> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ >> >> This patch updates the sync instructions to ensure that no insn is left >> without a type attribute. Updates a total of 6 insns to have type >> "atomic" >> >> Tested for regressions using rv32/64 multilib with newlib/linux. >> >> gcc/Changelog: >> >>     * config/riscv/sync-rvwmo.md: updated types to "multi" or >>      "atomic" based on number of assembly lines generated >>     * config/riscv/sync-ztso.md: likewise >>     * config/riscv/sync.md: likewise > OK. > > You should have your write access set up already.  So go ahead and > follow the directions in the email you received to get yourself into the > MAINTAINERS file.  Then you can go ahead and push this change. > > THanks, > Jeff > Committed! Edwin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id E60CB385843E for ; Fri, 25 Aug 2023 23:45:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E60CB385843E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qZgUG-0009iY-In for gcc-patches@gcc.gnu.org; Sat, 26 Aug 2023 01:45:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [Committed] RISC-V: Add Types to Un-Typed Sync Instructions: Date: Fri, 25 Aug 2023 16:44:57 -0700 Message-ID: References: <20230824211957.671151-1-ewlu@rivosinc.com> <5a02fd13-95af-768a-f61d-7daf890076fa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Cc: gnu-toolchain@rivosinc.com Content-Language: en-US In-Reply-To: <5a02fd13-95af-768a-f61d-7daf890076fa@gmail.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,BODY_8BITS,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230825234457.ypDjebsiB1X3AzUhHHpxXZak_rxm1Bm1z05ZAaLGMqQ@z> On 8/25/2023 11:53 AM, Jeff Law via Gcc-patches wrote: > > > On 8/24/23 15:19, Edwin Lu wrote: >> Related Discussion: >> https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ >> >> This patch updates the sync instructions to ensure that no insn is left >> without a type attribute. Updates a total of 6 insns to have type >> "atomic" >> >> Tested for regressions using rv32/64 multilib with newlib/linux. >> >> gcc/Changelog: >> >>     * config/riscv/sync-rvwmo.md: updated types to "multi" or >>      "atomic" based on number of assembly lines generated >>     * config/riscv/sync-ztso.md: likewise >>     * config/riscv/sync.md: likewise > OK. > > You should have your write access set up already.  So go ahead and > follow the directions in the email you received to get yourself into the > MAINTAINERS file.  Then you can go ahead and push this change. > > THanks, > Jeff > Committed! Edwin