* [committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175]
@ 2024-03-20 16:05 Jakub Jelinek
2024-03-20 17:01 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-03-20 16:05 UTC (permalink / raw)
To: gcc-patches
Hi!
Like for x86-64, alpha or rs6000, ft32 seems to be affected too.
Just visually checked differences in c23-stdarg-9.c assembly in a cross
without/with the patch, committed to trunk.
2024-03-20 Jakub Jelinek <jakub@redhat.com>
PR target/114175
* config/ft32/ft32.cc (ft32_setup_incoming_varargs): Only skip
function arg advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
if arg.type is NULL.
--- gcc/config/ft32/ft32.cc.jj 2024-01-03 12:01:22.988486000 +0100
+++ gcc/config/ft32/ft32.cc 2024-03-20 16:11:41.804969813 +0100
@@ -635,9 +635,10 @@ ft32_setup_incoming_varargs (cumulative_
{
CUMULATIVE_ARGS *cum = get_cumulative_args (cum_v);
int named_size = 0;
- if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl)))
- named_size =
- GET_MODE_SIZE (SImode) * (*cum - FT32_R0) + GET_MODE_SIZE (arg.mode);
+ if (!TYPE_NO_NAMED_ARGS_STDARG_P (TREE_TYPE (current_function_decl))
+ || arg.type != NULL_TREE)
+ named_size
+ = GET_MODE_SIZE (SImode) * (*cum - FT32_R0) + GET_MODE_SIZE (arg.mode);
if (named_size < 24)
*pretend_size = 24 - named_size;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175]
2024-03-20 16:05 [committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175] Jakub Jelinek
@ 2024-03-20 17:01 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2024-03-20 17:01 UTC (permalink / raw)
To: Jakub Jelinek, gcc-patches
On 3/20/24 10:05 AM, Jakub Jelinek wrote:
> Hi!
>
> Like for x86-64, alpha or rs6000, ft32 seems to be affected too.
>
> Just visually checked differences in c23-stdarg-9.c assembly in a cross
> without/with the patch, committed to trunk.
>
> 2024-03-20 Jakub Jelinek <jakub@redhat.com>
>
> PR target/114175
> * config/ft32/ft32.cc (ft32_setup_incoming_varargs): Only skip
> function arg advance for TYPE_NO_NAMED_ARGS_STDARG_P functions
> if arg.type is NULL.
Built fine. No gdbsim on this platform, so no execution test data.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-20 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-20 16:05 [committed] ft32: Fix up ft32_setup_incoming_varargs [PR114175] Jakub Jelinek
2024-03-20 17:01 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).