From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by sourceware.org (Postfix) with ESMTPS id 024013858C41 for ; Tue, 5 Mar 2024 09:57:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 024013858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 024013858C41 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.73 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709632632; cv=pass; b=QmZlb3goqjCobA9rulStsQTRv2gwFR/BoUw5+FItqs971YDK2HuiviAuu6ZAId/85rO4bzTG0N6UbL+7mu2YPNbyTIIkoXMHV1EezElkHguzYaqY1JhCDEfBempxtsE2B/RdESvlmRAP9sEBahTH8FhIvx4QDMsTvf5huSpQz9c= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709632632; c=relaxed/simple; bh=AXyzOfQRxs7EZq9LAbgPFnOFl1Qc6KWhRCM9eid1mXE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:From:To: MIME-Version; b=Xl8qlabnNWPvPCn0sAleI9iDXgPAihwizqNt3l6uY9rHZfZCKSPxxYMkPTsNOoCNzuJPpwESIc96Om0LcmDlC/TfsJm/6PI7yG/2ZNcPUCAPnhbzX/cvXfRpS0MublQcJKjYzkp1qzNIcXMhj0d0s92iCKK1PrMTY3zmcP7bioU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nzb7Oj76yS1Ra2dxtnpLZxSXOwjlEJixlgwvjg038rXE9vaUDcOrMRKs97CGrkRUvPc5tUyffgmJrYhJxXEwAfkCDRAV1lJtQPbrNWTgID1fs3Bptsen0f1UWeMzKToDJA2bd3VM+flxle9P43FOjkewM+myJu8XP+MXVq+KY9TaX/HmbdlrEeQb6n6gDL5vZAiqtoqfpTiPmgxjmpzw6fHd149bc5piV9dTTN5b22VqpJ8KN/4iwMzaraSyEi8G87GKWaW/fEPbwajN5XqT4nkErns+e86L9Dzy1Yz36LquXRKNjgABMZvU1rO9h1JeMHXWcD5/eSthfUwfn5ZUcw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwChvpWFNIl9EaHq0JCkqexKgikavey4kd1BKjA8FAo=; b=gZTXxI2gCDyHzSYrPZyCaoN2+LjPIwvEe0ejyXWZOR4pZ17oL4ETO6N6+DBh2/9muuhHAIaCWvzl0BnhaMvIMSLx/Fbk0tH4XsKB/Lhc1GepROsB4LIyRdb3buXxtIg4bJy1whYYQb8DGV3k8Z0KxWrwuDD2uocmuE2ks01SRge5YJn8Wq9tAY4s7m5DDU72o1PERw/xGB8oaTRAg2gMsz5NMl3NO3wmtw+4qtcSi44jypYl2mp1BflKJmoxx4nDiwOi8wISmR+Zoyd1BBe+rs+FWX9TdQOWdLS4ZNJFFxIFQoykGXgXcARoPR4yqpngqULAHvbfQi/g5SEph8S65A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwChvpWFNIl9EaHq0JCkqexKgikavey4kd1BKjA8FAo=; b=5N5sKVQh7bsGdyyxUUvcDSsAiLqHnSk7BXpGX4Sf5NFO8gXArCmYSlwmYyR9BdKoADzefQ81yW1ZquAlSVWYIz8wGjtCZsU7KOmofxCg/Ri2a5e6Rq37g4MX1EwLFq2KIPeFSb/sD6F/lb9EEeEd8zfj4aQbHaP9z7LmXuEUJmo= Received: from DU2PR04CA0051.eurprd04.prod.outlook.com (2603:10a6:10:234::26) by PAWPR08MB9100.eurprd08.prod.outlook.com (2603:10a6:102:341::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Tue, 5 Mar 2024 09:57:08 +0000 Received: from DB1PEPF000509F4.eurprd02.prod.outlook.com (2603:10a6:10:234:cafe::d0) by DU2PR04CA0051.outlook.office365.com (2603:10a6:10:234::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:57:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509F4.mail.protection.outlook.com (10.167.242.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:57:08 +0000 Received: ("Tessian outbound 7b0d57313a48:v276"); Tue, 05 Mar 2024 09:57:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b9d8e639a4ecc13a X-CR-MTA-TID: 64aa7808 Received: from 6ff92253f005.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 65B1EA20-C6D8-4D29-BAEE-F49C5CA974C8.1; Tue, 05 Mar 2024 09:56:56 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6ff92253f005.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Mar 2024 09:56:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niAp2fx8usTVDNXJNKOvMvHUWSPQ5xsb17gqPDRd49TE8CWuYQS/Y8+knfejlq9JhGwOlcHExKu0/XvL2uu6D8o2XOl4tZlHUJ6BHHGU5sz8kZggAY47Fcn+7wn1Y++Z7iirQGyQK1A5D2fLdjDM++37pFVAgeRFiJZatDTcAXmrHrKaQFt0uB+Kp1POb2i4X+8HH/7rW42IjyRFeq4JIVD8zgqmpdpkwg5TMncTx8BEcIXuVtdZejinrhhg7F13tBBR5ynnMnIhneUWyqEgVpCN9XjN8qDCcYl5fvYmm7VdSgH213HERNuQ5Z7TuOOw0eGlYmefFhqZWLpZ7rCk5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kwChvpWFNIl9EaHq0JCkqexKgikavey4kd1BKjA8FAo=; b=Qy1fJKifpwxWPPOay3aSIxTencv6e3a9b8DJhkOFJAWa/10sApoP4ZvCZtGYLV+SUw9D7O2mCTs4l3JAJI3SE36mWv0+cwExO2IKzVJLJeOD7UXHFNgydIdeIra6KvcHHrfZ8n0wAW/3WZSyvDRpNiYAg6bItWJAKS+Nawc+gq3+IKFwvHbJ9yy/Vw8t41DrpcMSCX3BsPOrr1oMhinh9lgZNhiGI7z0eRMbETVZs1CxUv508AbIo8ziKxrx6UWJ/+h1eVzm22s9Ns3NvWTnOrCMI1P4oecJDvVRS0xHK2O5gZD4w8kGFR4U1W6xcEZzkCMkDK5V+NXGYY4cy9EzAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kwChvpWFNIl9EaHq0JCkqexKgikavey4kd1BKjA8FAo=; b=5N5sKVQh7bsGdyyxUUvcDSsAiLqHnSk7BXpGX4Sf5NFO8gXArCmYSlwmYyR9BdKoADzefQ81yW1ZquAlSVWYIz8wGjtCZsU7KOmofxCg/Ri2a5e6Rq37g4MX1EwLFq2KIPeFSb/sD6F/lb9EEeEd8zfj4aQbHaP9z7LmXuEUJmo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) by AS8PR08MB10196.eurprd08.prod.outlook.com (2603:10a6:20b:62b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 09:56:53 +0000 Received: from DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::d078:cbfc:6500:3efd]) by DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::d078:cbfc:6500:3efd%7]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 09:56:53 +0000 Message-ID: Date: Tue, 5 Mar 2024 09:56:54 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] testsuite, arm: Fix testcase arm/pr112337.c to check for the options first Content-Language: en-US From: Saurabh Jha To: "Richard Earnshaw (lists)" , Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" References: <12c0edc0-4b22-4d7e-8ad5-1db0632f7cc5@arm.com> In-Reply-To: <12c0edc0-4b22-4d7e-8ad5-1db0632f7cc5@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0407.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::35) To DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DBBPR08MB6091:EE_|AS8PR08MB10196:EE_|DB1PEPF000509F4:EE_|PAWPR08MB9100:EE_ X-MS-Office365-Filtering-Correlation-Id: 3031b2d5-588a-491d-f182-08dc3cfa9ecc x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ED6vClBOIJsnxW6ZB5AbKyatx4f7Z84lpwBXgOcWygAmtcKPDCQ/K4fDYGT04BW8UWa6f4sdpIttAzujdAHzJFPttNc7VQH631dUSc4nI5yFtdkgMA4y3iZwLMMPXFuoUIPKAQMwy3izYv8G1vI0MijZuz4uRnotNsqqeg2oRn/jN6ayBW8ei1X/y+1ngi18oEh3f9bYp0jaft+6tngmgBSW61RnJW59TBbMVxQQ7UbhHlJVNIh1uA1aMwzHiPyySbsjrq5+KZBIhvLGGLDJmduDTkG499kGK8D9UXq8uiQAxUaxmnvLGgZUUSMEv2Vf0z/oR43CGkShSRLYO7yXDRRr8yUvrQBI1JMgBodD1uCJP+xVMHPLqozdmpkJa7tnH0CYXcg4bA1AH8Ayc/1xhos1JvApd+1QVVIckOXag/ULHwFAS0WAsncqkjoz8Xj8GROX1z6eCz5AYsE63m80fCCS4hHq7D8M4zMH+ftJ1wXmdjZbBIfedkulqcwSP4sb23Rv7+RlVWr4plo8Vy4GkZyH5bLt7qyOw56iucp/U64BPY/4ooJtkhA2C4cwEZxrLXKYxyAeeKUk+GQLJI3KhQsgUEYHNYrrGjkY3JkcuBY3XPrHlfEYl5hbFjCE+cTR X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB6091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10196 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F4.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b4c03d1-6a08-4d2c-66c7-08dc3cfa9598 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xUJu6rAkVTZf4G2fmC8lVBt+Z55HegIOBGE2T1z02ju0qetvehNpVg5wV0hO0AB38V/bFGyX4509ALyPHmFIWX6Qm7htP9XCwu7QGKGZGntZkVHxKeWersNn0YAyg91MZst6pE9SoACSfM2GNbmq7antFT3FoGAfpYlR2xiKi70a/rEVsGN/TLtPs3mwvwrRqUXSgyaFHpKYjC09Ib0Dv7jg0G3iTtF5KeU/HxFZJU/LnvwT1EJxWCe9353h18y5oYziedMO9Ivbl4hQktgEf2O2UCZ47aNBlell4o8nae2/VNQsxOrxIuZL2RmEtRiRdpa2HxV19yTF+5bIOvJugXs93vn4anFgmbXt707eMxgqmb7iE8l6/FfN9j5zbYcosS1DJ4NNK9hTXr65LZDPTqM6iKRgYiA8KYcbYXeI7n7W0nYhaR/3KVid0aTqdrSVIL7RdsZhSG4oB1o1YCIPEtCmKjFwd85cPm29iGYwHd7nJyhOj/WxHhl4AJeviHCLwB6vyFMlkg1VV3LnIznFptpesLfUbU3NX78Q8k4k3toN0OVIqjME8qI+JgGAop6NXIQYt7Oi9UVzjtiXZFlHtex7wbk/bcXNV5WUPbjaZl1XKwHuGnGcX2BJjHzVcjo3D0Vq8xlrblwu6nOMNOg6Li6eSeCxg6gEPPyMsW5acNGrWAaAPqYGlc3vM1uQKrImja29hTcgG0uvwFkEQ3LP/g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:57:08.3177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3031b2d5-588a-491d-f182-08dc3cfa9ecc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F4.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9100 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping On 2/19/2024 10:11 AM, Saurabh Jha wrote: > > On 2/9/2024 2:57 PM, Richard Earnshaw (lists) wrote: >> On 30/01/2024 17:07, Saurabh Jha wrote: >>> Hey, >>> >>> Previously, this test was added to fix this bug: >>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337. However, it did >>> not check the compilation options before using them, leading to errors. >>> >>> This patch fixes the test by first checking whether it can use the >>> options before using them. >>> >>> Tested for arm-none-eabi and found no regressions. The output of >>> check-gcc with RUNTESTFLAGS="arm.exp=*" changed like this: >>> >>> Before: >>> # of expected passes          5963 >>> # of unexpected failures      64 >>> >>> After: >>> # of expected passes          5964 >>> # of unexpected failures      63 >>> >>> Ok for master? >>> >>> Regards, >>> Saurabh >>> >>> gcc/testsuite/ChangeLog: >>> >>>          * gcc.target/arm/pr112337.c: Check whether we can use the >>> compilation options before using them. >> My apologies for missing this earlier.  It didn't show up in >> patchwork. That's most likely because the attachment is a binary blob >> instead of text/plain.  That also means that the Linaro CI system >> hasn't seen this patch either.  Please can you fix your mailer to add >> plain text patch files. >> >> -/* { dg-options "-O2 -march=armv8.1-m.main+fp.dp+mve.fp >> -mfloat-abi=hard" } */ >> +/* { dg-require-effective-target arm_hard_ok } */ >> +/* { dg-require-effective-target arm_v8_1m_mve_ok } */ >> +/* { dg-options "-O2 -mfloat-abi=hard" } */ >> +/* { dg-add-options arm_v8_1m_mve } */ >> >> This is moving in the right direction, but it adds more than >> necessary now: checking for, and adding -mfloat-abi=hard is not >> necessary any more as arm_v8_1m_mve_ok will work out what float-abi >> flags are needed to make the options work. (What's more, it will >> prevent the test from running if the base configuration of the >> compiler is incompatible with the hard float ABI, which is more than >> we need.). >> >> So please can you re-spin removing the hard-float check and removing >> that from dg-options. >> >> Thanks, >> R. > > Hi Richard, > > Agreed with your comments. Please find the patch with the suggested > changes attached. > > Regards, > > Saurabh >