From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mtlfep02.bell.net (belmont80srvr.owm.bell.net [184.150.200.80]) by sourceware.org (Postfix) with ESMTP id 3B416385041F for ; Tue, 25 Aug 2020 14:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B416385041F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=bell.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dave.anglin@bell.net Received: from bell.net mtlfep02 184.150.200.30 by mtlfep02.bell.net with ESMTP id <20200825143540.IEDG3628.mtlfep02.bell.net@mtlspm02.bell.net> for ; Tue, 25 Aug 2020 10:35:40 -0400 Received: from [192.168.2.49] (really [70.53.61.197]) by mtlspm02.bell.net with ESMTP id <20200825143540.BSRV3672.mtlspm02.bell.net@[192.168.2.49]>; Tue, 25 Aug 2020 10:35:40 -0400 Subject: Re: [PATCH] hppa: Improve expansion of ashldi3 when !TARGET_64BIT To: law@redhat.com, Roger Sayle , 'GCC Patches' References: <044501d677ba$099a5520$1cceff60$@nextmovesoftware.com> <6942a7b4-ec9b-0278-21e0-fa2f6a13b09b@bell.net> <00c701d67861$a1c37370$e54a5a50$@nextmovesoftware.com> From: John David Anglin Message-ID: Date: Tue, 25 Aug 2020 10:35:38 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-Analysis: v=2.3 cv=KoYzJleN c=1 sm=1 tr=0 a=6x1y2OhCX1CAR/Lk3lU3cg==:117 a=6x1y2OhCX1CAR/Lk3lU3cg==:17 a=IkcTkHD0fZMA:10 a=y4yBn9ojGxQA:10 a=FBHGMhGWAAAA:8 a=Cg4VZEBm31jtnzXWtBQA:9 a=QEXdDO2ut3YA:10 a=9gvnlMMaQFpL9xblJ6ne:22 X-CM-Envelope: MS4wfHoK7pHEJxjcPH06x8LbcDmGXRpw13GNhrfdWo5geJv3G6TeixjMbvjTseTRu59FMeb1NnIF2ZDty2VqwIFmEVRZukjz1U79u0RnV3DXX6hGMAtL+74c N1r8pESjr0oii5WdtaiE3R+uVftuEaJL4MCvq4tg4pJNLqSav11qF7XYm4YVdNuOaUvVHG16QYyvOg== X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 14:35:42 -0000 On 2020-08-25 10:05 a.m., Jeff Law wrote: > On Sat, 2020-08-22 at 09:52 +0100, Roger Sayle wrote: >> Hi Dave, >> >> It's great to hear from you. It's been a long while. >> >> Sorry, doh! yes, there's a mistake in my patch (that I introduced when I >> renumbered >> the operands in the shd's define_expand to be the more logical 0, 1, 2, 3, >> then 4). >> Sorry for the inconvenience [due to my lack of familiarity with PA-RISC >> assembly]. >> Hopefully you should get much better mileage out of the attached revision. > FWIW this version 3-staged in my tester and is currently running the testsuite. > It should finish testing later today. > > If David doesn't have objections, then I suggest going forward with the patch > independent of the others you've got queued up. The patch is fine.  Testing completed this morning on hpux and there are no regressions. Please install on trunk and gcc-10 branch. Thanks very much, Dave -- John David Anglin dave.anglin@bell.net