From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 044943858C55 for ; Wed, 31 Aug 2022 23:29:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 044943858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27VN1ULm006556; Wed, 31 Aug 2022 23:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=IolidyHQa4wT0E3VgL01SrHhxYZgyyejh1wEt2GJXVw=; b=pdvCwEr9H2cGCa/k7dUTr34KrgMtbTpw1WWuQkbQzd5L+uVvoTSM59jZtsZ/peNYEz3w +1A7UVtINOhJzY+jNnxfpKzOFvBW7HyyDZ7NxLBvTFdPVnt/xWDT/VrtD/jeUBv48uye JgfFsQjwyoE/s1ypU4naqiE73IpS1kCn4pfD3mxSDb2TuEoyJbv1WIPBxzDKkccuZvB5 ZlSumhtc4ntH+vwYnCxueVHRlB0OgEpwD9x+j59aR/eKWL+Q0fbkyc21fRoysbEana59 svLvjfsShNBG6GUcvWYy9o+UprkHOpiCajFeTrxgAeAxuJJSeI19Jz++4zpYHnHDTxu0 sg== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jagy1rv07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 23:29:05 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27VNLUqj016993; Wed, 31 Aug 2022 23:29:04 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma04wdc.us.ibm.com with ESMTP id 3j7aw9whhf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 23:29:04 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27VNT3sd6292160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Aug 2022 23:29:03 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01E04BE051; Wed, 31 Aug 2022 23:34:46 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 792C8BE04F; Wed, 31 Aug 2022 23:34:45 +0000 (GMT) Received: from [9.160.4.32] (unknown [9.160.4.32]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 31 Aug 2022 23:34:45 +0000 (GMT) Message-ID: Date: Wed, 31 Aug 2022 18:29:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] rs6000: Don't ICE when we disassemble an MMA variable [PR101322] Content-Language: en-US To: Segher Boessenkool Cc: "Kewen.Lin" , GCC Patches References: <9c6a44db-1239-466a-2990-42207b7eb264@linux.ibm.com> <6cf4ceb2-9deb-93b4-bd94-ab08c08eb330@linux.ibm.com> <20220831205126.GU25951@gate.crashing.org> <67da6fae-184d-4414-cb04-53e295abc477@linux.ibm.com> <20220831230807.GY25951@gate.crashing.org> From: Peter Bergner In-Reply-To: <20220831230807.GY25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1K_Xnu8K9nePhfhNQ5OiIbHzwZo8uteR X-Proofpoint-ORIG-GUID: 1K_Xnu8K9nePhfhNQ5OiIbHzwZo8uteR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-31_14,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208310111 X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/22 6:08 PM, Segher Boessenkool wrote: > On Wed, Aug 31, 2022 at 05:01:04PM -0500, Peter Bergner wrote: >> The problem goes away if I use use -O1 or above, I drop -flto or I use >> the code I originally posted without the ptr_vector_*_type >> >> The assert in gimple_canonical_types_compatible_p() we're hitting is: >> 13673 default: >> 13674 /* Consider all types with language specific trees in them mutually >> 13675 compatible. This is executed only from verify_type and false >> 13676 positives can be tolerated. */ >> 13677 gcc_assert (!in_lto_p); >> 13678 return true; >> >> I have no idea why ptr_vector_*_type would behave differently here than >> build_pointer_type (vector_*_type_node). Using the build_pointer_type() >> fixed it for me, so that's why I went with it. :-) Maybe this is a bug >> in lto??? > > It looks like left-over debugging code. Or this truly should never > happen in LTO? I have no idea. Either way, I'm going to go with the code that works, because either it's the "correct" code or it works around buggy code in lto. Either is a valid reason to me to use it. Peter