From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 144C53858D28 for ; Sun, 18 Jun 2023 18:11:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 144C53858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6686ef86110so217172b3a.2 for ; Sun, 18 Jun 2023 11:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687111864; x=1689703864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pc3zRPlNUqDnN7GlqtVs8sm2l+6jYvPPPtFKTf2z9Mc=; b=puSRFEZseUvZYVq9KO1XdAqic6pSFRobcz3L8lNJYYWdXHMPKiOn84UnWKahOiPq/R uuxpzv1HLt+gZQMdh/E0bhUaTggfZZh067+4DQfyyt4K74WRR1JpcTd0Y/5w9zAdUGH0 j73V1FAOB3uL/qOyJRek72lFih8AlE980dhSxqMcgcHwhZ7l3OqlUH49HLRl8H1nJDrd KBG9sS7S/Y5k5zQVlmjiqhj00chwBPTngOH77+sQOMFbQFvakct+pogYqTyT2YOSJO/E weV7H4eRTdmqx5Uabl355b4tbbMBh9TC4yfKRiX4jKaa0Wq0l1AalW9lNmHpe7M6BHu5 Ofig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687111864; x=1689703864; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pc3zRPlNUqDnN7GlqtVs8sm2l+6jYvPPPtFKTf2z9Mc=; b=Wzd2o7QA8CQ6u9qpGQ293tTpNvTB6UKekvp/tcxGgR8dOE/1NQvfQaVq7NeUQGsYST 1Iir9Q1sBqDHUwhsk7GkvexksrA97rC46Wmuz/TEkGtmdogRQyv3o79U7xkHL6FYciUs EeOPLXCs62bRQNOtrP2bBV/kNzkh5KU745QpqkX3ozLxc/yMd7efUusBnG1LTmXKxTAa 5Vx1rcgwW0cLinmQ4ZuM5qikczwKCWhoL5znnXXrZwy3p+wEp2YgDirGZoa489yypJdI DcHSP8wdxpjJ6J6Kgv17Y8JvhJbK+NFGxw9CGAs4sAWXgu+DPukCF1Ii3EIhP2v6UKgR p8Ng== X-Gm-Message-State: AC+VfDxZjuubFg52wCgrDyJH8a8NjXDW8G5ngqAAyTGaNUdECzqYOjtn LnxwQqkw2dhBnc8cc90P6EQ= X-Google-Smtp-Source: ACHHUZ5w1iN3vgGPplbBTXJQjUC4Q1BeBXwd7b2UJRxl2mAs8J6h/FcN+wxIgCtjtWeaVGk3x1MlEg== X-Received: by 2002:a05:6a20:3d11:b0:121:d478:4d91 with SMTP id y17-20020a056a203d1100b00121d4784d91mr247553pzi.16.1687111863799; Sun, 18 Jun 2023 11:11:03 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id j5-20020a170902c08500b001b4f77d4e7csm8436391pld.115.2023.06.18.11.11.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 11:11:03 -0700 (PDT) Message-ID: Date: Sun, 18 Jun 2023 12:11:01 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 0/2] RISC-V: New pass to optimize calculation of offsets for memory operations. Content-Language: en-US To: Manolis Tsamis Cc: gcc-patches@gcc.gnu.org, Richard Biener , Palmer Dabbelt , Philipp Tomsich , Kito Cheng References: <20230525123550.1072506-1-manolis.tsamis@vrull.eu> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/15/23 09:30, Manolis Tsamis wrote: >> > Thanks for reporting. I also noticed this while reworking the > implementation for v2 and I have fixed it among other things. Sounds good. I stumbled across another problem while testing V2. GEN_INT can create a non-canonical integer constant (and one might legitimately wonder if we should eliminate GEN_INT). The specific case I ran into was something like 0xfffffff0 for an SImode value on a 64bit host. That should have been 0xfffffffffffffff0 to be canonical. The right way to handle this these days is with gen_int_mode. You should replace the two calls to GEN_INT with gen_int_mode (new_offset, mode) Still testing the new variant... jeff