From: "Kewen.Lin" <linkw@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Bill Schmidt <wschmidt@linux.ibm.com>,
"bin.cheng" <bin.cheng@linux.alibaba.com>,
Richard Guenther <rguenther@suse.de>
Subject: [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling
Date: Thu, 16 Jan 2020 09:41:00 -0000 [thread overview]
Message-ID: <ddd8c186-fc88-96df-b1c0-f99edec654f2@linux.ibm.com> (raw)
Hi,
As we discussed in the thread
https://gcc.gnu.org/ml/gcc-patches/2020-01/msg00196.html
Original: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg00104.html,
I'm working to teach IVOPTs to consider D-form group access during unrolling.
The difference on D-form and other forms during unrolling is we can put the
stride into displacement field to avoid additional step increment. eg:
With X-form (uf step increment):
...
LD A = baseA, X
LD B = baseB, X
ST C = baseC, X
X = X + stride
LD A = baseA, X
LD B = baseB, X
ST C = baseC, X
X = X + stride
LD A = baseA, X
LD B = baseB, X
ST C = baseC, X
X = X + stride
...
With D-form (one step increment for each base):
...
LD A = baseA, OFF
LD B = baseB, OFF
ST C = baseC, OFF
LD A = baseA, OFF+stride
LD B = baseB, OFF+stride
ST C = baseC, OFF+stride
LD A = baseA, OFF+2*stride
LD B = baseB, OFF+2*stride
ST C = baseC, OFF+2*stride
...
baseA += stride * uf
baseB += stride * uf
baseC += stride * uf
Imagining that if the loop get unrolled by 8 times, then 3 step updates with
D-form vs. 8 step updates with X-form. Here we only need to check stride
meet D-form field requirement, since if OFF doesn't meet, we can construct
baseA' with baseA + OFF.
This patch set consists four parts:
[PATCH 1/4 GCC11] Add middle-end unroll factor estimation
Add unroll factor estimation in middle-end. It mainly refers to current
RTL unroll factor determination in function decide_unrolling and its
sub calls. As Richard B. suggested, we probably can force unroll factor
with this and avoid duplicate unroll factor calculation, but I think it
need more benchmarking work and should be handled separately.
[PATCH 2/4 GCC11] Add target hook stride_dform_valid_p
Add one target hook to determine whether the current memory access with
the given mode, stride and other flags have available D-form supports.
[PATCH 3/4 GCC11] IVOPTs Consider cost_step on different forms during unrolling
Teach IVOPTs to identify address type iv group with D-form preferred,
and flag dform_p of their derived iv cands. Considering unroll factor,
increase iv cost with (uf - 1) * cost_step if it's not a dform iv cand.
[PATCH 4/4 GCC11] rs6000: P9 D-form test cases
Add some test cases, mainly copied from Kelvin's patch.
Bootstrapped and regress tested on powerpc64le-linux-gnu.
I'll take two weeks leave soon, please expect late responses.
Thanks a lot in advance!
BR,
Kewen
------------
gcc/cfgloop.h | 3 +
gcc/config/rs6000/rs6000.c | 56 ++++++++++++++++-
gcc/doc/tm.texi | 14 +++++
gcc/doc/tm.texi.in | 4 ++
gcc/target.def | 21 ++++++-
gcc/testsuite/gcc.target/powerpc/p9-dform-0.c | 43 +++++++++++++
gcc/testsuite/gcc.target/powerpc/p9-dform-1.c | 55 +++++++++++++++++
gcc/testsuite/gcc.target/powerpc/p9-dform-2.c | 12 ++++
gcc/testsuite/gcc.target/powerpc/p9-dform-3.c | 15 +++++
gcc/testsuite/gcc.target/powerpc/p9-dform-4.c | 12 ++++
gcc/testsuite/gcc.target/powerpc/p9-dform-generic.h | 34 +++++++++++
gcc/tree-ssa-loop-ivopts.c | 84 +++++++++++++++++++++++++-
gcc/tree-ssa-loop-manip.c | 254 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
gcc/tree-ssa-loop-manip.h | 3 +-
gcc/tree-ssa-loop.c | 33 ++++++++++
gcc/tree-ssa-loop.h | 2 +
16 files changed, 640 insertions(+), 5 deletions(-)
next reply other threads:[~2020-01-16 9:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 9:41 Kewen.Lin [this message]
2020-01-16 9:43 ` [PATCH 1/4 GCC11] Add middle-end unroll factor estimation Kewen.Lin
2020-01-20 13:12 ` Segher Boessenkool
2020-02-10 6:20 ` [PATCH 1/4 v2 " Kewen.Lin
2020-02-10 23:34 ` Segher Boessenkool
2020-02-11 6:51 ` [PATCH 1/4 v3 " Kewen.Lin
2020-02-11 7:00 ` Segher Boessenkool
2020-02-11 2:15 ` [PATCH 1/4 v2 " Jiufu Guo
2020-02-11 3:04 ` Kewen.Lin
2020-01-16 10:02 ` [PATCH 2/4 GCC11] Add target hook stride_dform_valid_p Kewen.Lin
2020-01-20 10:53 ` Richard Sandiford
2020-01-20 11:47 ` Richard Biener
2020-01-20 13:20 ` Segher Boessenkool
2020-02-25 9:46 ` Kewen.Lin
2020-03-02 11:09 ` Richard Sandiford
2020-03-03 12:26 ` Kewen.Lin
2020-05-13 5:50 ` Kewen.Lin
2020-05-28 2:17 ` Ping^1 [PATCH 2/4 V3] " Kewen.Lin
2020-05-28 10:54 ` Richard Sandiford
2020-01-16 10:06 ` [PATCH 3/4 GCC11] IVOPTs Consider cost_step on different forms during unrolling Kewen.Lin
2020-02-25 9:48 ` [PATCH 3/4 V2 " Kewen.Lin
2020-05-13 5:42 ` [PATCH 3/4 V3 " Kewen.Lin
2020-01-16 10:12 ` [PATCH 4/4 GCC11] rs6000: P9 D-form test cases Kewen.Lin
2020-01-20 13:37 ` Segher Boessenkool
2020-02-10 6:25 ` [PATCH 4/4 v2 " Kewen.Lin
2020-02-10 23:51 ` Segher Boessenkool
2020-01-20 13:03 ` [PATCH 0/4 GCC11] IVOPTs consider step cost for different forms when unrolling Segher Boessenkool
2020-02-10 6:17 ` Kewen.Lin
2020-02-10 21:29 ` Segher Boessenkool
2020-02-11 2:56 ` Kewen.Lin
2020-02-11 7:34 ` Richard Biener
2020-02-11 7:49 ` Segher Boessenkool
2020-02-11 8:01 ` Richard Biener
2020-02-11 12:46 ` Roman Zhuykov
2020-02-11 13:58 ` Richard Biener
2020-02-11 18:00 ` Segher Boessenkool
2020-02-12 8:07 ` Richard Biener
2020-02-12 21:53 ` Segher Boessenkool
2020-02-11 18:12 ` Segher Boessenkool
2020-02-12 8:13 ` Richard Biener
2020-02-12 10:02 ` Segher Boessenkool
2020-02-12 10:53 ` Richard Biener
2020-02-12 22:05 ` Segher Boessenkool
2020-02-13 7:48 ` Richard Biener
2020-02-13 9:02 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddd8c186-fc88-96df-b1c0-f99edec654f2@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bin.cheng@linux.alibaba.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).