From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BC2A03858D37 for ; Thu, 22 Jun 2023 23:42:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC2A03858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MNCGSV017890 for ; Thu, 22 Jun 2023 23:42:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=dV3JffGG00cNKVQEj8tJNHajEeL8FBzANxIOCUk+tqg=; b=U1UgO/eB+kgQjG6djki6EnVMtOK10IxHg4TpG6Y6udNQbOOtc1wGrr4xx/BpIK9YULXn ZvhZPBS2P62f6pupryS3CjvBvV7tLty4Q/bgxei+XlvO8rh4gv0rW7gwHgINXiUblNqX mdrZYNSGc8x8iHDmwMy9iUM8mgFPwI9/0b7V2l9TyRXBFErFOPwN2cVGc8oCsLzQeN7W kmgkzkK86+cPDi9OrUcvOKYZmJCziGuZOpyCBtZ/4G/2QvKYxinXBCr1LLc8m44+jpx+ 1TTY7tIrWj9Juq6Q301NSAT28ExZVDaqsH3WK6iFngVKvUWNJt0h/YGzil+wTC2SYTML pQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcyrv8kwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 22 Jun 2023 23:42:50 +0000 Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35MNgo29009589 for ; Thu, 22 Jun 2023 23:42:50 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcyrv8kw9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:42:50 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35MKLms9016692; Thu, 22 Jun 2023 23:37:49 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3r94f6c3kk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:37:49 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MNblwO63832332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 23:37:47 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5332E58056; Thu, 22 Jun 2023 23:37:47 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19DC95803F; Thu, 22 Jun 2023 23:37:47 +0000 (GMT) Received: from [9.61.29.17] (unknown [9.61.29.17]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 23:37:47 +0000 (GMT) Message-ID: Date: Thu, 22 Jun 2023 18:37:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS Content-Language: en-US To: Ian Lance Taylor , "Paul E. Murphy" Cc: gcc-patches@gcc.gnu.org References: <20230616160002.1854983-1-murphyp@linux.ibm.com> From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: N3b_T2Vd3WcKieiKWLWInQCypsWYuENz X-Proofpoint-GUID: jk2Q1Lt6TuM0nfwfQCpgd6YUW2M_Ktic X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_17,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220203 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/16/23 12:01 PM, Ian Lance Taylor via Gcc-patches wrote: > On Fri, Jun 16, 2023 at 9:00 AM Paul E. Murphy via Gcc-patches > wrote: >> >> TARGET_AIX is defined to a non-zero value on linux and maybe other >> powerpc64le targets. This leads to unexpected behavior such as >> dropping the .go_export section when linking a shared library >> on linux/powerpc64le. >> >> Instead, use TARGET_AIX_OS to toggle AIX specific behavior. >> >> Fixes golang/go#60798. >> >> gcc/go/ChangeLog: >> >> * go-backend.cc [TARGET_AIX]: Rename and update usage to >> TARGET_AIX_OS. >> * go-lang.cc: Likewise. > > This is OK. > > Thanks. > > Ian I pushed this to trunk for Paul. Peter