From: Tom de Vries <tdevries@suse.de>
To: Richard Biener <richard.guenther@gmail.com>,
Feng Xue OS <fxue@os.amperecomputing.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Thomas Schwinge <thomas@codesourcery.com>,
Jeff Law <law@redhat.com>
Subject: [committed][nvptx, libgomp] Update pr85381-{2,4}.c test-cases
Date: Sat, 15 Jun 2019 12:05:00 -0000 [thread overview]
Message-ID: <de112548-506a-fe58-9e1d-88309b5c5c6c@suse.de> (raw)
In-Reply-To: <CAFiYyc0Rack5sTGZ0fFfPupcZvHx+YADY3ZFNBLAEvLhgOyneg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
[ was: Re: [PATCH V8] Remove empty loop with assumed finiteness (PR
tree-optimization/89713) ]
On 12-06-19 11:42, Richard Biener wrote:
> On Tue, Jun 11, 2019 at 4:40 AM Feng Xue OS <fxue@os.amperecomputing.com> wrote:
>>
>> Reformat to comply with gcc coding style.
>
> OK for trunk.
>
Committed patch to update nvptx test-cases.
Thanks,
- Tom
[-- Attachment #2: 0001-nvptx-libgomp-Update-pr85381-2-4-.c-test-cases.patch --]
[-- Type: text/x-patch, Size: 2471 bytes --]
[nvptx, libgomp] Update pr85381-{2,4}.c test-cases
After the fix for "PR tree-optimization/89713 - Assume loop with an exit is
finite" ( r272234 ) empty oacc loops are removed before expand.
Update pr85381-{2,4}.c accordingly.
2019-06-15 Tom de Vries <tdevries@suse.de>
PR tree-optimization/89713
* testsuite/libgomp.oacc-c-c++-common/pr85381-2.c: Expect no bar.sync.
* testsuite/libgomp.oacc-c-c++-common/pr85381-4.c: Same.
---
.../testsuite/libgomp.oacc-c-c++-common/pr85381-2.c | 20 +-------------------
.../testsuite/libgomp.oacc-c-c++-common/pr85381-4.c | 5 +----
2 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-2.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-2.c
index 6570c64afff..2cb5b95949d 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-2.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-2.c
@@ -15,22 +15,4 @@ main (void)
return 0;
}
-/* Todo: Boths bar.syncs can be removed.
- Atm we generate this dead code inbetween forked and joining:
-
- mov.u32 %r28, %ntid.y;
- mov.u32 %r29, %tid.y;
- add.u32 %r30, %r29, %r29;
- setp.gt.s32 %r31, %r30, 19;
- @%r31 bra $L2;
- add.u32 %r25, %r28, %r28;
- mov.u32 %r24, %r30;
- $L3:
- add.u32 %r24, %r24, %r25;
- setp.le.s32 %r33, %r24, 19;
- @%r33 bra $L3;
- $L2:
-
- so the loop is not recognized as empty loop (which we detect by seeing if
- joining immediately follows forked). */
-/* { dg-final { scan-assembler-times "bar.sync" 2 } } */
+/* { dg-final { scan-assembler-times "bar.sync" 0 } } */
diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-4.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-4.c
index d955d79718d..e8a433ffc0a 100644
--- a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-4.c
+++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr85381-4.c
@@ -21,7 +21,4 @@ main (void)
return 0;
}
-/* Atm, %ntid.y is broadcast from one loop to the next, so there are 2 bar.syncs
- for that (the other two are there for the same reason as in pr85381-2.c).
- Todo: Recompute %ntid.y instead of broadcasting it. */
-/* { dg-final { scan-assembler-times "bar.sync" 4 } } */
+/* { dg-final { scan-assembler-times "bar.sync" 0 } } */
next prev parent reply other threads:[~2019-06-15 12:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 4:17 [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713) Feng Xue OS
2019-05-17 16:47 ` Jeff Law
2019-05-17 18:50 ` Richard Biener
2019-05-18 14:00 ` Marc Glisse
2019-05-20 7:50 ` Richard Biener
2019-05-20 8:27 ` Feng Xue OS
2019-05-20 9:19 ` Richard Biener
2019-05-20 9:48 ` Feng Xue OS
2019-05-20 11:54 ` Richard Biener
2019-05-20 14:00 ` Feng Xue OS
2019-05-20 14:04 ` Richard Biener
2019-05-20 14:51 ` Feng Xue OS
2019-05-21 10:12 ` Richard Biener
2019-05-21 14:24 ` Richard Biener
2019-05-22 13:44 ` Michael Matz
2019-05-24 16:02 ` [PATCH V3] " Feng Xue OS
2019-05-24 9:15 ` [PATCH V2] " Feng Xue OS
2019-05-29 11:16 ` Richard Biener
2019-06-04 6:49 ` [PATCH V4] " Feng Xue OS
2019-06-04 8:24 ` Marc Glisse
2019-06-04 15:16 ` [PATCH V5] " Feng Xue OS
2019-06-04 15:24 ` [PATCH V6] " Feng Xue OS
2019-06-05 11:05 ` Richard Biener
2019-06-06 10:00 ` [PATCH V7] " Feng Xue OS
2019-06-11 2:40 ` [PATCH V8] " Feng Xue OS
2019-06-12 9:43 ` Richard Biener
2019-06-15 12:05 ` Tom de Vries [this message]
2019-05-20 13:04 ` [PATCH] " Marc Glisse
2019-05-20 13:26 ` Richard Biener
2019-05-20 14:49 ` Michael Matz
2019-05-21 8:06 ` Marc Glisse
2020-04-01 13:36 ` [PATCH][RFC] c/94392 - only enable -ffinite-loops for C++ Richard Biener
2020-04-01 13:47 ` Jakub Jelinek
2020-04-01 13:52 ` Richard Biener
2020-04-01 15:56 ` Jan Hubicka
2020-04-01 16:59 ` Richard Biener
2020-04-01 19:15 ` Jason Merrill
2020-04-02 9:12 ` Richard Biener
2020-04-02 9:17 ` Jakub Jelinek
2020-04-02 9:41 ` Richard Biener
2020-04-03 8:29 ` Revert "[nvptx, libgomp] Update pr85381-{2, 4}.c test-cases" [PR89713, PR94392] (was: [PATCH][RFC] c/94392 - only enable -ffinite-loops for C++) Thomas Schwinge
2020-04-03 9:36 ` Revert "[nvptx, libgomp] Update pr85381-{2,4}.c " Richard Biener
2020-04-03 10:34 ` Jakub Jelinek
2020-10-30 14:09 ` Revert "[nvptx, libgomp] Update pr85381-{2, 4}.c " Thomas Schwinge
2020-10-30 14:16 ` Revert "[nvptx, libgomp] Update pr85381-{2,4}.c " Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de112548-506a-fe58-9e1d-88309b5c5c6c@suse.de \
--to=tdevries@suse.de \
--cc=fxue@os.amperecomputing.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).