From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id B31443858C74 for ; Tue, 9 Jan 2024 18:18:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B31443858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B31443858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704824284; cv=none; b=kEJE8xifGXjJZpLMOF0asOpYPYicMPxFw4+ZKm3m4NNq4kExRd1EQssegC+Qi2AB8t2P+qwenR2OXudWv846SfgyBtzWkVl3b8ZyNHOa0w25XkkT9YtuVvR/ZjENDNR8n4xsSYe98rIBl9DV+wfdjuwM03vD2cOLy7sAn1+KZ+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704824284; c=relaxed/simple; bh=nwUXEnenvCdv0dETPF/4JOJf3N+55yuKa35iA8JIWvE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JZNot0S0Co48cZg2R+4/gP8uTHehA18NzpkEg9TYL76YdxSWtb9X5DKCHfAVvEONmVPI4P/oTjfZmfALvey47Kf3AU9FDud35wnGHVUkVcEwdSzs9Spxzqhd6mF02CQRCX/rHGuScV1/5yAntQsp5NzFLp7F+JQtSe0oUdPWz2Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7bee6a5ba1aso21914139f.1 for ; Tue, 09 Jan 2024 10:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704824282; x=1705429082; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yJdmE8Ogd/HcPKUA79RAt75RpsqPE4+NMEJ7X1cpryM=; b=I0EFF9zEeSvuMtXVAf8uhHmUnlhSJiS056qcLtEOPqfGKL1OKljrHjVgo4GlYK1Aqx 1r5fsV1G47NccSVCLHJ1QnDxR+sAIVNYYLsClZ5pEDUuIlz2rJD8Hu+nGIAMS5SMk6C9 r/1ghv8wbmM0VA/DisAek/bBXDzB5wDLQKnRO+l1nf9WaJeP4fjCwNlCLPKYEzlW9qkX M6JHPnfuECZ4Soe2ACQCmIqyxAaN3zdx3XiAzcG7X9M6hw875cy425iYgrc7Yx7HxFiH RNtxyfejxs6tn2q8WrMwqevEfEMRe2cgHdGHa0vvgrJrP7i9UQzaP+/cTeoEXpowhrVI WKxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704824282; x=1705429082; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yJdmE8Ogd/HcPKUA79RAt75RpsqPE4+NMEJ7X1cpryM=; b=fOSnViLojkYoX3l2pgz0QXaEBOuuiskbULh+ncVlmvW1UqNBkzhggsSc3sWheCwLZf S32Mp37Pr9BEKQ4IbnX+685MD7KM/T8WwgV0+nKC7RQQJJ4a+kaY2VF4VgUCnm2nvMfF tm1FbrvGP28iyLJvcdit1pe11Idb0e+NARsVEUj58rtHD+tpWkJ02hE+8L4czYwl6jxv L35sqMmmLV9fqBeJuOuuVIYfDDLdjuBtlYodvVygN46pfhuo/TGKXN9Tu+SgvmJ4TrPY zclwyq+vSNZaJYz5EbMKYr5SA1jbN5kfopbe2zCE8v1U738kEXnXWDoF9iVzrZjKhoCp XeTA== X-Gm-Message-State: AOJu0YyaTTWTrhkQ+oQUf7UVefnvEH5dyt26UPku1/Be1GWDApHFYj3M kpc6pJclqEH33JTKc6IuzV8= X-Google-Smtp-Source: AGHT+IEzpHTreqYldNO3ZYC3q5Vf4/wf/wGOvpgUEJg1aKx5zFa9o/6E9e//0Q0TnmYQJmvsX+4TLQ== X-Received: by 2002:a05:6602:18:b0:7bc:329d:574 with SMTP id b24-20020a056602001800b007bc329d0574mr6842775ioa.29.1704824281884; Tue, 09 Jan 2024 10:18:01 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id do33-20020a0566384ca100b0046df601152dsm789140jab.66.2024.01.09.10.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 10:18:01 -0800 (PST) Message-ID: Date: Tue, 9 Jan 2024 11:17:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c-family: copy attribute diagnostic fixes [PR113262] Content-Language: en-US To: Jakub Jelinek , "Joseph S. Myers" , Jason Merrill , Marek Polacek Cc: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/9/24 01:52, Jakub Jelinek wrote: > Hi! > > The copy attributes is allowed on decls as well as types and even has > checks whether decl (set to *node) is DECL_P or TYPE_P, but for diagnostics > unconditionally uses DECL_SOURCE_LOCATION (decl), which obviously only works > if it applies to a decl. > > The following patch fixes that, bootstrapped/regtested on x86_64-linux and > i686-linux, ok for trunk? > > 2024-01-09 Jakub Jelinek > > PR c/113262 > * c-attribs.cc (handle_copy_attribute): Don't use > DECL_SOURCE_LOCATION (decl) if decl is not DECL_P, use input_location > instead. Formatting fixes. > > * gcc.dg/pr113262.c: New test. ok Jeff