From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 15F043858D37 for ; Thu, 22 Jun 2023 23:47:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15F043858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MNgxTt010816 for ; Thu, 22 Jun 2023 23:47:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Mn1zlHcEYzAVgvMvxoiaFXGSlJfzMns2BCTxa0imak4=; b=RGjq4krlHGtRsJttfD1EqCNXZavxfesuijnFxEoHrJ16om/NWlfDwjWG7R4YhNg3aAkQ Rx9Eo+e8sR8vFyhn2EVizVNz/rEcUfSG40b3ZR5iXXbXlliDkBpz+jnKscocGfKFXTub YcmX6jMk4DkkHYhmO4bIAwjSZMmEgK1cETzcyXaOT+Jsq8/wHAjaA19LS/rARmTSmXPi J8sGKYKY8O5fEVSkl4dDSKngkWRScEbQQmDC1gxX+nwn/otrpGej41gkHNl61h65+hs6 rl/HvMxWyHALpW4O8fk08zKd3m1TYrz/lr0NOR5+c0qC0v6m+p8HGh25Jjqv0duwM0Zt 4A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcxy4hbb2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 22 Jun 2023 23:47:00 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35MNh6uf011988 for ; Thu, 22 Jun 2023 23:46:59 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcxy4hbau-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:46:59 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35MME6MY010286; Thu, 22 Jun 2023 23:46:58 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3r94f73hde-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 23:46:58 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MNkui663898002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 23:46:57 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B036058063; Thu, 22 Jun 2023 23:46:56 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 455005803F; Thu, 22 Jun 2023 23:46:56 +0000 (GMT) Received: from [9.61.29.17] (unknown [9.61.29.17]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 23:46:56 +0000 (GMT) Message-ID: Date: Thu, 22 Jun 2023 18:46:55 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS Content-Language: en-US To: Ian Lance Taylor , "Paul E. Murphy" Cc: gcc-patches@gcc.gnu.org References: <20230616160002.1854983-1-murphyp@linux.ibm.com> From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LzH-pRuKrIywCgLhtEPjnXYrc4dbgVLe X-Proofpoint-GUID: owCt4D9UGMGdT61dX1FTsgFT7M3xpFoT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_17,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220203 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/22/23 6:37 PM, Peter Bergner via Gcc-patches wrote: > On 6/16/23 12:01 PM, Ian Lance Taylor via Gcc-patches wrote: >> On Fri, Jun 16, 2023 at 9:00 AM Paul E. Murphy via Gcc-patches >> wrote: >>> >>> TARGET_AIX is defined to a non-zero value on linux and maybe other >>> powerpc64le targets. This leads to unexpected behavior such as >>> dropping the .go_export section when linking a shared library >>> on linux/powerpc64le. >>> >>> Instead, use TARGET_AIX_OS to toggle AIX specific behavior. >>> >>> Fixes golang/go#60798. >>> >>> gcc/go/ChangeLog: >>> >>> * go-backend.cc [TARGET_AIX]: Rename and update usage to >>> TARGET_AIX_OS. >>> * go-lang.cc: Likewise. >> >> This is OK. >> >> Thanks. >> >> Ian > > I pushed this to trunk for Paul. I see this is broken on the release branches too. Are backports ok after some burn-in on trunk? Peter