From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5CE3D3858C2D for ; Thu, 8 Sep 2022 19:35:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CE3D3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662665716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HPMMYEHNSEMNlnL9WmjEpGIqFph6LNfLOzQ5w8A3jtU=; b=OsrCtL6UMTXEHDwu7KcS1TjkCdt6Va7tD/G6z0pF40eji1CUG62CiMkI6nz7uXb1S0tErs o1D2rFGSoLIlN2k6LAzcetYrSfHiH4wkz2kMOQm+uCHP5amKyhDADAXLNIuuVF3HD5xgWO N3HylOfLrZyUBvMgopWJZrmAJMP0+jc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-511-ED0QN98lOX-zcBH5-2HtAQ-1; Thu, 08 Sep 2022 15:35:15 -0400 X-MC-Unique: ED0QN98lOX-zcBH5-2HtAQ-1 Received: by mail-qt1-f199.google.com with SMTP id v13-20020a05622a188d00b00343794bd1daso15533854qtc.23 for ; Thu, 08 Sep 2022 12:35:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=HPMMYEHNSEMNlnL9WmjEpGIqFph6LNfLOzQ5w8A3jtU=; b=qUf0NapxlXoO2jOYdKaIj7ix8Iwr8Fx+VfoBEfC6zfrpbNwBpOFRuOsT30bq2p5UdL DiVuLWGELnYAqcpQPwND+7EV2HFHhWGWSCCAoVchF4lNrAxuFRtHFWSmYrfDZjULVGRF PSUB/EAMDiGPAR/SQrk+PCZmHPdGBeSXVUz+e5Px0G0J8EfwnJKAmXpEfLpuViGFB6GB J73mEJ6W/pl8OCnh64LVEN+/g73hfkAXTcdIbm1m7WOEEqzTcOMZcS22mBxp4JyEs0vx m0+9lJRRG4hS7ZcZ3qkKIC4+DSPE/ukeODS8rMZ2le4SnGWc+8hqlVXmfwx8IeOdbRHk 7vHQ== X-Gm-Message-State: ACgBeo3b/0BqOYWwhRdqO4LdUwokY36iKQiLHuZLn++Cmw5KWL6KOGJf g+3pRkFnliRJNhw/s4UJYh4eN/pebiFsbn2R90ATfAUh9oalE8TtQDVEiqZEHBYdZdSlZ8Yk1Mu z9ye5ypbOpXOBEFbhCg== X-Received: by 2002:a0c:802c:0:b0:478:de2c:9b6f with SMTP id 41-20020a0c802c000000b00478de2c9b6fmr9275680qva.89.1662665714418; Thu, 08 Sep 2022 12:35:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Uss1iCNEOAo62oC63KELlf60zz0y48OH+AqbWtE18I6oE9Vf/PA8A1yLy0Y7/fowVW9b/qQ== X-Received: by 2002:a0c:802c:0:b0:478:de2c:9b6f with SMTP id 41-20020a0c802c000000b00478de2c9b6fmr9275658qva.89.1662665714113; Thu, 08 Sep 2022 12:35:14 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id d6-20020ac85446000000b0034454d0c8f3sm14769121qtq.93.2022.09.08.12.35.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 12:35:13 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 15:35:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] optc-save-gen.awk: adjust generated array compare To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Chung-Lin Tang , gcc-patches Cc: Sandra Loosemore , Joseph Myers References: <56951572-c9b4-af2d-0e8b-9d47b87ba313@codesourcery.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/8/22 14:01, Martin Liška wrote: > On 9/8/22 18:23, Jason Merrill wrote: >> It seems to me that the warning is pointing out that comparing the address of the array is nonsensical, and we should remove it and just have the memcmp. > > Yes, thanks for the pointer. We should always compare the array types with memcmp. > > Ready to be installed? OK.