From: Nathan Sidwell <nathan@acm.org>
To: Jakub Jelinek <jakub@redhat.com>, Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Optimize void COND_EXPRs during cp_fold (PR c++/81675)
Date: Mon, 27 Nov 2017 12:44:00 -0000 [thread overview]
Message-ID: <de8bcdcb-1e58-5ac9-0870-6b1fa13685d6@acm.org> (raw)
In-Reply-To: <20171124213500.GA14653@tucnak>
On 11/24/2017 04:35 PM, Jakub Jelinek wrote:
> Hi!
>
> The comment says that trying to fold VOID_TYPE_P COND_EXPRs is not worth
> bothering, but as the following testcase shows, that is not the case.
> fold_ternary can optimize COND_EXPRs where the condition is constant and
> the unused branch doesn't have any labels, and not folding it early means
> bogus warnings afterwards.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
ok, thanks
nathan
--
Nathan Sidwell
prev parent reply other threads:[~2017-11-27 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 21:42 Jakub Jelinek
2017-11-27 12:44 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8bcdcb-1e58-5ac9-0870-6b1fa13685d6@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).