From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13391 invoked by alias); 15 May 2007 08:05:37 -0000 Received: (qmail 13380 invoked by uid 22791); 15 May 2007 08:05:36 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.173) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 May 2007 08:05:33 +0000 Received: by ug-out-1314.google.com with SMTP id s2so1121942uge for ; Tue, 15 May 2007 01:05:30 -0700 (PDT) Received: by 10.67.94.3 with SMTP id w3mr944837ugl.1179216330026; Tue, 15 May 2007 01:05:30 -0700 (PDT) Received: by 10.67.73.20 with HTTP; Tue, 15 May 2007 01:05:29 -0700 (PDT) Message-ID: Date: Tue, 15 May 2007 08:05:00 -0000 From: "Andrew Pinski" To: "Thomas Neumann" Subject: Re: [PATCH] compiling gcc with a C++ compiler 4/n Cc: gcc-patches@gcc.gnu.org In-Reply-To: <46496564.1070603@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <46496564.1070603@users.sourceforge.net> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-05/txt/msg00944.txt.bz2 On 5/15/07, Thomas Neumann wrote: > > > Also by the way you need to list all the functions you are > > changing. And say more of what you are doing in your changelog > > entries because right now they are lacking and not to what the coding > > style says they should be. > sorry for this, I only submit patches since a few days... Could you be a > bit more specific about what I should write? I interpreted the FSF > instructions such that: > - if a changes is all over the place (renaming a member e.g.) you just > write "func:c: What did I change" Nobody does that ever really. An example of where (yes it was mine) something used all over the place changed the name can be found in ChangeLog-2006: 2006-12-12 Andrew Pinski PR tree-opt/28436 * tree.h (DECL_COMPLEX_GIMPLE_REG_P): Rename to ... (DECL_GIMPLE_REG_P): This. * fold-const.c (fold_indirect_ref_1): Fold *(foo *)&vectorfoo into using BIT_FIELD_REF. * omp-low.c (omp_copy_decl_2): Use the renamed DECL_GIMPLE_REG_P. * tree-gimple.c (is_gimple_reg): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. .... * gimplify.c (internal_get_tmp_var): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. (gimplify_bind_expr): Likewise. (gimplify_function_tree): Likewise. You can use likewise if needed to make the changeLog a little shorter. The only time I know of a "toplevel" changelog entry is when you are changing includes. Another example can be found with "2006-12-10 Andrew MacLeod ". > - if it is indeed limited to a function you write "func.c (func): What > did I change in the func". If this was true then the changelogs in GCC would be much smaller than they are. > Or do you mean that "Cast as needed" etc. is too generic? I will write > as detailed descriptions as you like, but I thought that explaining the > reasons for obvious casts was not really helpful. Both. I would take a look at the existing changelogs. A better entry for "Cast as needed" would be "Add casts for coding style." Plus the entries should always be full sentences. >Bootstrapped on i686, testing still running. Ok if it succeeeds? Don't send out patches until they are fully tested, it just wastes time on both your part and the reviewer's part. Oh and double checking you have your copyright assignment in place right? Thanks, Andrew Pinski