public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Andrew Pinski" <pinskia@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix pragma-darwin.c (and turn on for i386-darwin also)
Date: Sun, 29 Jul 2007 23:09:00 -0000	[thread overview]
Message-ID: <de8d50360707291523g41b5495eufbca95968c9d04bf@mail.gmail.com> (raw)
In-Reply-To: <99E47762-D3A5-4735-8997-7FFDFD0FD698@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On 7/29/07, Andrew Pinski <pinskia@gmail.com> wrote:
> Hi,
>    This path fixes the testcase for the dg-error/dg-warning change so
> that the warnings are now marked with dg-warning.  This patch also
> turns on this testcase for i386-darwin.
>
> OK? Tested on i386-darwin with no regressions.

I knew I forgot something, the changelog:
* gcc.dg/pragma-darwin.c: Run on all *-*-darwin* targets.
s/dg-error/dg-warning where warning is expected.

Thanks,
Andrew Pinski

[-- Attachment #2: fixpragma-darwin.c.diff.txt --]
[-- Type: text/plain, Size: 1872 bytes --]

Index: gcc.dg/pragma-darwin.c
===================================================================
--- gcc.dg/pragma-darwin.c	(revision 127042)
+++ gcc.dg/pragma-darwin.c	(working copy)
@@ -1,6 +1,6 @@
 /* Darwin (Mac OS X) pragma exercises.  */
 
-/* { dg-do run { target powerpc-*-darwin* } } */
+/* { dg-do run { target *-*-darwin* } } */
 /* { dg-options "-O -Wunused" } */
 
 /* The mark pragma is to help decorate IDEs.  */
@@ -12,11 +12,11 @@
 /* The options pragma used to do a lot, now it's only for emulating
    m68k alignment rules in structs.  */
 
-#pragma options 23  /* { dg-error "malformed '#pragma options'" } */
-#pragma options align  /* { dg-error "malformed '#pragma options'" } */
-#pragma options align natural /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=45 /* { dg-error "malformed '#pragma options'" } */
-#pragma options align=foo /* { dg-error "malformed '#pragma options align" } */
+#pragma options 23  /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align  /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align natural /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=45 /* { dg-warning "malformed '#pragma options'" } */
+#pragma options align=foo /* { dg-warning "malformed '#pragma options align" } */
 
 #ifndef __LP64__
 #pragma options align=mac68k
@@ -64,7 +64,7 @@
 {
   int a, b;
   /* Trying to match on '(' or ')' gives regexp headaches, use . instead.  */
-#pragma unused  /* { dg-error "missing '.' after '#pragma unused" } */
-#pragma unused (a  /* { dg-error "missing '.' after '#pragma unused" } */
+#pragma unused  /* { dg-warning "missing '.' after '#pragma unused" } */
+#pragma unused (a  /* { dg-warning "missing '.' after '#pragma unused" } */
 #pragma unused (b) foo /* { dg-warning "junk at end of '#pragma unused'" } */
 }

  reply	other threads:[~2007-07-29 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 22:24 Andrew Pinski
2007-07-29 23:09 ` Andrew Pinski [this message]
2007-07-30 18:34 ` Janis Johnson
2007-07-29 23:52 Dominique Dhumieres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8d50360707291523g41b5495eufbca95968c9d04bf@mail.gmail.com \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).