From: "Andrew Pinski" <pinskia@gmail.com>
To: "Ian Lance Taylor" <iant@google.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH RFC: More control over which functions are instrumented
Date: Wed, 01 Aug 2007 21:59:00 -0000 [thread overview]
Message-ID: <de8d50360708011458v6ffbbc2emc937dcc511b2c68f@mail.gmail.com> (raw)
In-Reply-To: <m3k5sfgc2b.fsf@localhost.localdomain>
On 01 Aug 2007 14:49:32 -0700, Ian Lance Taylor <iant@google.com> wrote:
> -finstrument-functions-exclude-function-list is there because it seems
> odd to not have it, but the more commonly used option will be
> -finstrument-functions-exclude-file-list. Note that files are matched
> as substrings, so you can say
> -finstrument-functions-exclude-file-list=include/c++ to exclude any
> function defined in a file in ...include/c++...
Ick, basing on where the function is defined seems like a hack. That
is like the non NO_IMPLICIT_EXTERN_C problem. Maybe I see this as
less useful than the instrument vs inline function issue. You never
know people might have an include/c++ directory in their source tree
too which includes their C++ headers. This one of the reasons why I
think it is less useful.
Thanks,
Andrew Pinski
next prev parent reply other threads:[~2007-08-01 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 20:22 Ian Lance Taylor
2007-08-01 21:26 ` Andrew Pinski
2007-08-01 21:51 ` Ian Lance Taylor
2007-08-01 21:59 ` Andrew Pinski [this message]
2007-08-07 23:48 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8d50360708011458v6ffbbc2emc937dcc511b2c68f@mail.gmail.com \
--to=pinskia@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).