From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11185 invoked by alias); 1 Aug 2007 21:59:02 -0000 Received: (qmail 11170 invoked by uid 22791); 1 Aug 2007 21:59:01 -0000 X-Spam-Check-By: sourceware.org Received: from wa-out-1112.google.com (HELO wa-out-1112.google.com) (209.85.146.178) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Aug 2007 21:58:57 +0000 Received: by wa-out-1112.google.com with SMTP id m16so319183waf for ; Wed, 01 Aug 2007 14:58:55 -0700 (PDT) Received: by 10.115.74.1 with SMTP id b1mr1141190wal.1186005534506; Wed, 01 Aug 2007 14:58:54 -0700 (PDT) Received: by 10.114.203.9 with HTTP; Wed, 1 Aug 2007 14:58:54 -0700 (PDT) Message-ID: Date: Wed, 01 Aug 2007 21:59:00 -0000 From: "Andrew Pinski" To: "Ian Lance Taylor" Subject: Re: PATCH RFC: More control over which functions are instrumented Cc: gcc-patches@gcc.gnu.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00083.txt.bz2 On 01 Aug 2007 14:49:32 -0700, Ian Lance Taylor wrote: > -finstrument-functions-exclude-function-list is there because it seems > odd to not have it, but the more commonly used option will be > -finstrument-functions-exclude-file-list. Note that files are matched > as substrings, so you can say > -finstrument-functions-exclude-file-list=include/c++ to exclude any > function defined in a file in ...include/c++... Ick, basing on where the function is defined seems like a hack. That is like the non NO_IMPLICIT_EXTERN_C problem. Maybe I see this as less useful than the instrument vs inline function issue. You never know people might have an include/c++ directory in their source tree too which includes their C++ headers. This one of the reasons why I think it is less useful. Thanks, Andrew Pinski