[PATCH] FIx PR midde-end/32935 ICE in emit_move_insn due to fold producing type mismatch with negative and fp

[PATCH] FIx PR midde-end/32935 ICE in emit_move_insn due to fold producing type mismatch with negative and fp

[Andrew Pinski]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Hi,
  The problem here is that fold strips off the floating point
extensions but then does not convert the negative expression back to
the original type which causes a type mismatch.  This causes either an
ICE with the extra checking Richard Guenther added or an ICE in
emit_move_insn.  This patch here adds a fold_convert to convert to the
correct type after the negate expression.

OK?  Bootstrapped and tested on i686-apple-darwin8.10 with no regressions.

Thanks,
Andrew Pinski

* fold-convert.c (fold_negate_expr <NOP_EXPR>): Convert back to the correct
type the negate expression.

* gfortran.fortran-torture/compile/complex_1.f90: New test

[-- Attachment #2: fixpr32935.diff.txt --]
[-- Type: text/plain, Size: 792 bytes --]

Index: fold-const.c
===================================================================
--- fold-const.c	(revision 127176)
+++ fold-const.c	(working copy)
@@ -1382,7 +1382,7 @@ fold_negate_expr (tree t)
 	{
 	  tem = strip_float_extensions (t);
 	  if (tem != t && negate_expr_p (tem))
-	    return negate_expr (tem);
+	    return fold_convert (type, negate_expr (tem));
 	}
       break;
 
Index: testsuite/gfortran.fortran-torture/compile/complex_1.f90
===================================================================
--- testsuite/gfortran.fortran-torture/compile/complex_1.f90	(revision 0)
+++ testsuite/gfortran.fortran-torture/compile/complex_1.f90	(revision 0)
@@ -0,0 +1,5 @@
+program test_gfortran2
+ Complex(8) :: g, zh
+ Real(8)    :: g_q
+ g =   zh - zh/cmplx(0.0_8,-g_q)
+end

Re: [PATCH] FIx PR midde-end/32935 ICE in emit_move_insn due to fold producing type mismatch with negative and fp

[Diego Novillo]

On 8/3/07 10:45 AM, Andrew Pinski wrote:

> * fold-convert.c (fold_negate_expr <NOP_EXPR>): Convert back to the correct
> type the negate expression.
> 
> * gfortran.fortran-torture/compile/complex_1.f90: New test

OK